UpdateHelper::updateAllFields() - Code Metrics - Inspection of "Add UpdateHelper (from storage)" - drycart/data - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 644c62...cdc390 )

by Max

created 2020-07-01 20:17 UTC

UpdateHelper::updateAllFields() A

↳ Parent: UpdateHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php
/*
 *  @copyright (c) 2019 Mendel <[email protected]>
 *  @license see license.txt
 */

namespace drycart\data;

/**
 * Description of UpdateHelper
 *
 * @author mendel
 */
class UpdateHelper
{
    // Dont change order - longer will be first (before other started from same symbols)
    const RULES = ['set:', 'sum:', 'max:', 'min:'];
    
    public static function updateAllFields(&$data, array $changes) : void
    {
        foreach($changes as $key=>$value) {
            [$rule, $fieldName] = StrHelper::findPrefix($key, static::RULES, 'set:');

            static::updateField($data, $value, $rule, $fieldName);
        }
    }
    
    public static function updateField(&$data, $value, string $rule, string $fieldName) : void
    {
        $current = $data[$fieldName];
        switch ($rule) {
            case 'set:':
                $data[$fieldName] = $value;
                break;
            case 'sum:':
                $data[$fieldName] = ($current ?? 0) + $value;
                break;
            case 'max:':
                $data[$fieldName] = max([$current, $value]);
                break;
            case 'min:':
                $data[$fieldName] = min([$current, $value]);
                break;
            default:
                throw new \Exception('Unknown type '.$rule);
        }
    }
}


1			<?php
2			/*
3			* @copyright (c) 2019 Mendel <[email protected]>
4			* @license see license.txt
5			*/
6
7			namespace drycart\data;
8
9			/**
10			* Description of UpdateHelper
11			*
12			* @author mendel
13			*/
14			class UpdateHelper
15			{
16			// Dont change order - longer will be first (before other started from same symbols)
17			const RULES = ['set:', 'sum:', 'max:', 'min:'];
18
19			public static function updateAllFields(&$data, array $changes) : void
20			{
21			foreach($changes as $key=>$value) {
22			[$rule, $fieldName] = StrHelper::findPrefix($key, static::RULES, 'set:');
			0 ignored issues – show Bug introduced 2020-07-01 20:18 UTC by Report Bug Copy Issue Report The variable `$rule` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2020-07-01 20:18 UTC by Report Bug Copy Issue Report The variable `$fieldName` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
23			static::updateField($data, $value, $rule, $fieldName);
24			}
25			}
26
27			public static function updateField(&$data, $value, string $rule, string $fieldName) : void
28			{
29			$current = $data[$fieldName];
30			switch ($rule) {
31			case 'set:':
32			$data[$fieldName] = $value;
33			break;
34			case 'sum:':
35			$data[$fieldName] = ($current ?? 0) + $value;
36			break;
37			case 'max:':
38			$data[$fieldName] = max([$current, $value]);
39			break;
40			case 'min:':
41			$data[$fieldName] = min([$current, $value]);
42			break;
43			default:
44			throw new \Exception('Unknown type '.$rule);
45			}
46			}
47			}
48

drycart / data

Push — master ( 644c62...cdc390 )

UpdateHelper::updateAllFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like