Pi::run() - Code Metrics - Inspection of "Complete refactoring - using stateless and immutab..." - drupol/yaroc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Pol

created 2018-05-17 18:33 UTC

Pi::run() A

↳ Parent: Pi

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	21
ccs	0
cts	16
cp	0
rs	9.3142
cc	3
eloc	12
nc	3
nop	1
crap	12

<?php

namespace drupol\Yaroc\Examples;

use drupol\Yaroc\Plugin\Provider;

/**
 * Class Pi.
 */
class Pi extends BaseExample
{
    /**
     * @var float
     */
    protected $estimation;

    /**
     * @param int $n
     *
     * @throws \Http\Client\Exception
     *
     * @return $this
     */
    public function run($n = 1000)

    {
        $provider = Provider::withResource('generateDecimalFractions')
            ->withParameters(['n' => $n * 2, 'decimalPlaces' => 6]);

        $numbers = $this->getRandomOrgAPI()->getData($provider);

        $inside = 0;
        for ($i = 0; $i < $n; $i++) {
            $x = $numbers[$i];

            $y = $numbers[$i+1];


            if (sqrt($x*$x + $y*$y) <= 1) {
                $inside++;
            }
        }

        $this->estimation = 4 * $inside/$n;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        return $this;
    }

    /**
     * @return float
     */
    public function get()
    {
        return $this->estimation;
    }
}


1			<?php
2
3			namespace drupol\Yaroc\Examples;
4
5			use drupol\Yaroc\Plugin\Provider;
6
7			/**
8			* Class Pi.
9			*/
10			class Pi extends BaseExample
11			{
12			/**
13			* @var float
14			*/
15			protected $estimation;
16
17			/**
18			* @param int $n
19			*
20			* @throws \Http\Client\Exception
21			*
22			* @return $this
23			*/
24			public function run($n = 1000)
			0 ignored issues – show Comprehensibility introduced 2018-05-17 09:19 UTC by Report Bug Copy Issue Report Avoid variables with short names like $n. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
25			{
26			$provider = Provider::withResource('generateDecimalFractions')
27			->withParameters(['n' => $n * 2, 'decimalPlaces' => 6]);
28
29			$numbers = $this->getRandomOrgAPI()->getData($provider);
30
31			$inside = 0;
32			for ($i = 0; $i < $n; $i++) {
33			$x = $numbers[$i];
			0 ignored issues – show Comprehensibility introduced 2016-11-27 15:33 UTC by Report Bug Copy Issue Report Avoid variables with short names like $x. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
34			$y = $numbers[$i+1];
			0 ignored issues – show Comprehensibility introduced 2016-11-27 15:33 UTC by Report Bug Copy Issue Report Avoid variables with short names like $y. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
35
36			if (sqrt($x$x + $y$y) <= 1) {
37			$inside++;
38			}
39			}
40
41			$this->estimation = 4 * $inside/$n;
			0 ignored issues – show Documentation Bug introduced 2016-11-27 15:19 UTC by Report Bug Copy Issue Report The property `$estimation` was declared of type `double`, but `4 * $inside / $n` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
42
43			return $this;
44			}
45
46			/**
47			* @return float
48			*/
49			public function get()
50			{
51			return $this->estimation;
52			}
53			}
54

drupol / yaroc

Pull Request — master (#2)

Pi::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like