drupol\Yaroc\Examples\Pi

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	23	3
A	get()	0	4	1

<?php

namespace drupol\Yaroc\Examples;

use drupol\Yaroc\Plugin\Method\GenerateDecimalFractions;

/**
 * Class Pi.
 */
class Pi extends BaseExample
{
    /**
     * @var float
     */
    protected $estimation;

    /**
     * @param int $n
     *
     * @throws \Http\Client\Exception
     *
     * @return $this
     */
    public function run($n = 1000)

Avoid variables with short names like $n. Configured minimum length is 3.

The variable $GenerateDecimalFractions is not named in camelCase.

    {
        $parameters = ['n' => $n * 2, 'decimalPlaces' => 6];

        $GenerateDecimalFractions = (new GenerateDecimalFractions($this->getHttpClient()))

The variable name $GenerateDecimalFractions exceeds the maximum configured length of 20.

            ->withParameters($parameters);

        $numbers = $this->getRandomOrgAPI()->getData($GenerateDecimalFractions);

        $inside = 0;
        for ($i = 0; $i < $n; $i++) {
            $x = $numbers[$i];

Avoid variables with short names like $x. Configured minimum length is 3.

            $y = $numbers[$i+1];

Avoid variables with short names like $y. Configured minimum length is 3.

            if (sqrt($x*$x + $y*$y) <= 1) {
                $inside++;
            }
        }

        $this->estimation = 4 * $inside/$n;

The property $estimation was declared of type double, but 4 * $inside / $n is of type integer. Maybe add a type cast?

        return $this;
    }

    /**
     * @return float
     */
    public function get()
    {
        return $this->estimation;
    }
}