Location::find() - Code Metrics - Inspection of "Complete refactoring - using stateless and immutab..." - drupol/yaroc - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#2)

by Pol

created 2018-05-16 19:36 UTC

Location::find() A

↳ Parent: Location

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
ccs	0
cts	13
cp	0
rs	9.4285
cc	1
eloc	10
nc	1
nop	0
crap	2

<?php

namespace drupol\Yaroc\Examples;

use drupol\Yaroc\Plugin\Method\GenerateDecimalFractions;

/**
 * Class Location.
 */
class Location extends BaseExample
{

    /**
     * @var double[]
     */
    protected $coordinates;

    /**
     * @throws \Http\Client\Exception
     *
     * @return $this
     */
    public function find()
    {
        $parameters = ['n' => 3, 'decimalPlaces' => 10];

        $generateIntegers = (new GenerateDecimalFractions($this->getHttpClient()))
            ->withParameters($parameters);

        $result = $this->getRandomOrgAPI()->getData($generateIntegers);

        $this->coordinates = [

            'x' => rad2deg($result[0] * 2 * pi() - pi()),
            'y' => rad2deg(pi()/2 - acos($result[1] * 2 - 1)),
            'z' => $result[2] * 1000,
        ];

        return $this;
    }

    /**
     * Get the coordinates.
     *
     * @return double[]
     */
    public function getCoordinates()
    {
        return $this->coordinates;
    }
}


1			<?php
2
3			namespace drupol\Yaroc\Examples;
4
5			use drupol\Yaroc\Plugin\Method\GenerateDecimalFractions;
6
7			/**
8			* Class Location.
9			*/
10			class Location extends BaseExample
11			{
12
13			/**
14			* @var double[]
15			*/
16			protected $coordinates;
17
18			/**
19			* @throws \Http\Client\Exception
20			*
21			* @return $this
22			*/
23			public function find()
24			{
25			$parameters = ['n' => 3, 'decimalPlaces' => 10];
26
27			$generateIntegers = (new GenerateDecimalFractions($this->getHttpClient()))
28			->withParameters($parameters);
29
30			$result = $this->getRandomOrgAPI()->getData($generateIntegers);
31
32			$this->coordinates = [
			0 ignored issues – show Documentation Bug introduced 2018-05-16 15:53 UTC by Report Bug Copy Issue Report It seems like `array('x' => rad2deg($re...' => $result[2] * 1000)` of type `array<string,double\|inte...,"z":"integer\|double"}>` is incompatible with the declared type `array<integer,double>` of property `$coordinates`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
33			'x' => rad2deg($result[0] * 2 * pi() - pi()),
34			'y' => rad2deg(pi()/2 - acos($result[1] * 2 - 1)),
35			'z' => $result[2] * 1000,
36			];
37
38			return $this;
39			}
40
41			/**
42			* Get the coordinates.
43			*
44			* @return double[]
45			*/
46			public function getCoordinates()
47			{
48			return $this->coordinates;
49			}
50			}
51

drupol / yaroc

Pull Request — master (#2)

Location::find() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like