Location::find() - Code Metrics - Inspection of "Add more examples and their tests." - drupol/yaroc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3718bf...59e23c )

by Pol

created 2016-12-04 01:03 UTC

Location::find() A

↳ Parent: Location

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0
crap	1

<?php

namespace drupol\Yaroc\Examples;

/**
 * Class Location.
 *
 * @package drupol\Yaroc\Examples
 */
class Location extends BaseExample {

  /**
   * @var double[]
   */
  protected $coordinates;

  /**
   * Find random location.
   *
   * @return self
   */
  public function find() {
    $result = $this->randomOrgAPI->call('generateDecimalFractions', ['n' => 3, 'decimalPlaces' => 10])
      ->getData();

    $this->coordinates = [

      'x' => rad2deg($result[0] * 2 * pi() - pi()),
      'y' => rad2deg(pi()/2 - acos($result[1] * 2 - 1)),
      'z' => $result[2] * 1000,
    ];

    return $this;
  }

  /**
   * Get the coordinates.
   *
   * @return string

   */
  public function getCoordinates() {
    return $this->coordinates;
  }

}


1		<?php
2
3		namespace drupol\Yaroc\Examples;
4
5		/**
6		* Class Location.
7		*
8		* @package drupol\Yaroc\Examples
9		*/
10		class Location extends BaseExample {
11
12		/**
13		* @var double[]
14		*/
15		protected $coordinates;
16
17		/**
18		* Find random location.
19		*
20		* @return self
21		*/
22	1	public function find() {
23	1	$result = $this->randomOrgAPI->call('generateDecimalFractions', ['n' => 3, 'decimalPlaces' => 10])
24	1	->getData();
25
26	1	$this->coordinates = [
		0 ignored issues – show Documentation Bug introduced 2016-12-04 01:06 UTC by Report Bug Copy Issue Report It seems like `array('x' => rad2deg($re...' => $result[2] * 1000)` of type `array<string,double\|inte...,"z":"integer\|double"}>` is incompatible with the declared type `array<integer,double>` of property `$coordinates`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27	1	'x' => rad2deg($result[0] * 2 * pi() - pi()),
28	1	'y' => rad2deg(pi()/2 - acos($result[1] * 2 - 1)),
29	1	'z' => $result[2] * 1000,
30		];
31
32	1	return $this;
33		}
34
35		/**
36		* Get the coordinates.
37		*
38		* @return string
		0 ignored issues – show Documentation introduced 2016-12-04 01:06 UTC by Report Bug Copy Issue Report Should the return type not be `double[]`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
39		*/
40	1	public function getCoordinates() {
41	1	return $this->coordinates;
42		}
43
44		}
45

drupol / yaroc

Push — master ( 3718bf...59e23c )

Location::find() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like