drupol\Yaroc\Examples\Time

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	find()	0	12	1
A	get()	0	3	1

<?php

namespace drupol\Yaroc\Examples;

/**
 * Class Time.
 *
 * @package drupol\Yaroc\Examples
 */
class Time extends BaseExample {

  /**
   * @var int[]
   */
  protected $time;

  /**
   * Find random time.
   *
   * @return self
   */
  public function find() {

The variable $minutes_seconds is not named in camelCase.

    $hours = $this->randomOrgAPI->call('generateIntegers', ['n' => 1, 'min' => 0, 'max' => 23])->getData();
    $minutes_seconds = $this->randomOrgAPI->call('generateIntegers', ['n' => 2, 'min' => 0, 'max' => 59])->getData();

    $this->time = [

It seems like array('h' => $hours[0], 'm' => $minutes_seconds[0], 's' => $minutes_seconds[1]) of type array<string,?,{"h":"?","m":"?","s":"?"}> is incompatible with the declared type array<integer,integer> of property $time.

      'h' => $hours[0],
      'm' => $minutes_seconds[0],
      's' => $minutes_seconds[1],
    ];

    return $this;
  }

  /**
   * Get the time.
   *
   * @return string

Should the return type not be integer[]?

   */
  public function get() {
    return $this->time;
  }

}