drupol / yaroc

src/Examples/Pi.php

<?php

namespace drupol\Yaroc\Examples;

/**
 * Class Pi.
 *
 * @package drupol\Yaroc\Examples
 */
class Pi extends BaseExample {

  /**
   * @var float
   */
  protected $estimation;

  /**
   * @return self
   */
  public function run($n = 1000) {

Avoid variables with short names like $n. Configured minimum length is 3.

    $numbers = $this->randomOrgAPI->call('generateDecimalFractions', ['n' => $n * 2, 'decimalPlaces' => 6])
      ->getData();

    $inside = 0;
    for ($i = 0; $i < $n; $i++) {
      $x = $numbers[$i];

Avoid variables with short names like $x. Configured minimum length is 3.

      $y = $numbers[$i+1];

Avoid variables with short names like $y. Configured minimum length is 3.

      if (sqrt($x*$x + $y*$y) <= 1) {
        $inside++;
      }
    }

    $this->estimation = 4 * $inside/$n;

The property $estimation was declared of type double, but 4 * $inside / $n is of type integer. Maybe add a type cast?

    return $this;
  }

  public function get() {
    return $this->estimation;
  }

}