Client::validateResponse() - Code Metrics - Inspection of "Try to fix tests on PHP7." - drupol/yaroc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 73ec26...13e542 )

by Pol

created 2016-11-28 12:01 UTC

Client::validateResponse() C

↳ Parent: Client

Complexity

Conditions	7
Paths	7

Size

Total Lines	24
Code Lines	17

Duplication

Lines	8
Ratio	33.33 %

Code Coverage

Tests	7
CRAP Score	19.3458

Importance

Changes

Metric	Value
dl	8
loc	24
ccs	7
cts	19
cp	0.3684
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	17
nc	7
nop	1
crap	19.3458

<?php

namespace drupol\Yaroc\Http;

use drupol\Yaroc\Http\Client\Common\Plugin\LoggerPlugin;
use drupol\Yaroc\Http\Message\Formatter\Formatter;
use drupol\Yaroc\Plugin\MethodPluginInterface;
use Http\Client\Common\HttpMethodsClient;
use Http\Client\Common\Plugin\HeaderDefaultsPlugin;
use Http\Client\Common\PluginClient;
use Http\Client\Exception\NetworkException;
use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\UriFactoryDiscovery;
use Http\Message\UriFactory;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;
use Psr\Log\LoggerInterface;

/**
 * Class Client
 *
 * @package drupol\Yaroc\Http
 */
class Client extends HttpMethodsClient {


  /**
   * The default Random.org endpoint.
   *
   * @var UriInterface
   */
  protected $endpoint;

  /**
   * The URI Factory.
   *
   * @var UriFactory
   */
  protected $uriFactory;

  /**
   * The logger.
   *
   * @var \Psr\Log\LoggerInterface
   */
  protected $logger;

  /**
   * Client constructor.
   *
   * @param \Http\Client\HttpClient|NULL $httpClient
   * @param \Http\Message\UriFactory|NULL $uriFactory
   * @param \Psr\Log\LoggerInterface|NULL $logger
   */
  public function __construct(HttpClient $httpClient = NULL, UriFactory $uriFactory = NULL, LoggerInterface $logger = NULL) {
    $httpClient = $httpClient ?: HttpClientDiscovery::find();

    $plugins = [
      new HeaderDefaultsPlugin(['Content-Type' => 'application/json']),
      new LoggerPlugin($logger ?: new \drupol\Yaroc\Log\Logger(), new Formatter()),
    ];
    $httpClient = new HttpMethodsClient(new PluginClient($httpClient, $plugins), MessageFactoryDiscovery::find());

    $this->setUriFactory($uriFactory ?: UriFactoryDiscovery::find());
    parent::__construct($httpClient, MessageFactoryDiscovery::find());
  }

  /**
   * Set the Random.org endpoint.
   *
   * @param string $uri
   */
  public function setEndpoint($uri) {
    $this->endpoint = $this->getUriFactory()->createUri($uri);
  }

  /**
   * Get the Random.org endpoint.
   *
   * @return UriInterface
   */
  public function getEndpoint() {
    return $this->endpoint;
  }

  /**
   * Request.
   *
   * @param MethodPluginInterface $methodPlugin
   *
   * @return null|ResponseInterface
   */
  public function request(MethodPluginInterface $methodPlugin) {
    try {
      $response = $this->post($this->getEndpoint(), [], json_encode($methodPlugin->getParameters()));
    } catch (NetworkException $e) {
      return NULL;
    }

    return $this->validateResponse($response);
  }

  /**
   * Validate the response.
   *
   * @param \Psr\Http\Message\ResponseInterface $response
   *
   * @return \Exception|ResponseInterface
   */
  public function validateResponse(ResponseInterface $response) {
    if (200 == $response->getStatusCode()) {
      $body = json_decode((string) $response->getBody()->getContents(), TRUE);

      if (isset($body['error']['code'])) {
        switch ($body['error']['code']) {
          case -32600:

            throw new \InvalidArgumentException('Invalid Request: ' . $body['error']['message'], $body['error']['code']);
          case -32601:
            throw new \BadFunctionCallException('Procedure not found: ' . $body['error']['message'], $body['error']['code']);
          case -32602:

            throw new \InvalidArgumentException('Invalid arguments: ' . $body['error']['message'], $body['error']['code']);
          case -32603:

            throw new \RuntimeException('Internal Error: ' . $body['error']['message'], $body['error']['code']);
          default:

            throw new \RuntimeException('Invalid request/response: ' . $body['error']['message'], $body['error']['code']);
        }
      }
    }

    $response->getBody()->rewind();

    return $response;
  }

  /**
   * Get the logger.
   *
   * @return \Psr\Log\LoggerInterface
   */
  public function getLogger() {
    return $this->logger;
  }

  /**
   * Set the logger.
   *
   * @param \Psr\Log\LoggerInterface $logger
   */
  public function setLogger(LoggerInterface $logger) {
    $this->logger = $logger;
  }

  /**
   * Returns the UriFactory.
   *
   * @return \Http\Message\UriFactory
   */
  public function getUriFactory() {
    return $this->uriFactory;
  }

  /**
   * @param \Http\Message\UriFactory $uriFactory
   */
  public function setUriFactory(UriFactory $uriFactory) {
    $this->uriFactory = $uriFactory;
  }

}


1			<?php
2
3			namespace drupol\Yaroc\Http;
4
5			use drupol\Yaroc\Http\Client\Common\Plugin\LoggerPlugin;
6			use drupol\Yaroc\Http\Message\Formatter\Formatter;
7			use drupol\Yaroc\Plugin\MethodPluginInterface;
8			use Http\Client\Common\HttpMethodsClient;
9			use Http\Client\Common\Plugin\HeaderDefaultsPlugin;
10			use Http\Client\Common\PluginClient;
11			use Http\Client\Exception\NetworkException;
12			use Http\Client\HttpClient;
13			use Http\Discovery\HttpClientDiscovery;
14			use Http\Discovery\MessageFactoryDiscovery;
15			use Http\Discovery\UriFactoryDiscovery;
16			use Http\Message\UriFactory;
17			use Psr\Http\Message\ResponseInterface;
18			use Psr\Http\Message\UriInterface;
19			use Psr\Log\LoggerInterface;
20
21			/**
22			* Class Client
23			*
24			* @package drupol\Yaroc\Http
25			*/
26			class Client extends HttpMethodsClient {
			0 ignored issues – show Complexity introduced 2016-11-27 15:33 UTC by Report Bug Copy Issue Report The class Client has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13. Loading history...
27
28			/**
29			* The default Random.org endpoint.
30			*
31			* @var UriInterface
32			*/
33			protected $endpoint;
34
35			/**
36			* The URI Factory.
37			*
38			* @var UriFactory
39			*/
40			protected $uriFactory;
41
42			/**
43			* The logger.
44			*
45			* @var \Psr\Log\LoggerInterface
46			*/
47			protected $logger;
48
49			/**
50			* Client constructor.
51			*
52			* @param \Http\Client\HttpClient\|NULL $httpClient
53			* @param \Http\Message\UriFactory\|NULL $uriFactory
54			* @param \Psr\Log\LoggerInterface\|NULL $logger
55			*/
56	15		public function __construct(HttpClient $httpClient = NULL, UriFactory $uriFactory = NULL, LoggerInterface $logger = NULL) {
57	15		$httpClient = $httpClient ?: HttpClientDiscovery::find();
58
59			$plugins = [
60	15		new HeaderDefaultsPlugin(['Content-Type' => 'application/json']),
61	15		new LoggerPlugin($logger ?: new \drupol\Yaroc\Log\Logger(), new Formatter()),
62	15		];
63	15		$httpClient = new HttpMethodsClient(new PluginClient($httpClient, $plugins), MessageFactoryDiscovery::find());
64
65	15		$this->setUriFactory($uriFactory ?: UriFactoryDiscovery::find());
66	15		parent::__construct($httpClient, MessageFactoryDiscovery::find());
67	15		}
68
69			/**
70			* Set the Random.org endpoint.
71			*
72			* @param string $uri
73			*/
74	15		public function setEndpoint($uri) {
75	15		$this->endpoint = $this->getUriFactory()->createUri($uri);
76	15		}
77
78			/**
79			* Get the Random.org endpoint.
80			*
81			* @return UriInterface
82			*/
83	12		public function getEndpoint() {
84	12		return $this->endpoint;
85			}
86
87			/**
88			* Request.
89			*
90			* @param MethodPluginInterface $methodPlugin
91			*
92			* @return null\|ResponseInterface
93			*/
94	12		public function request(MethodPluginInterface $methodPlugin) {
95			try {
96	12		$response = $this->post($this->getEndpoint(), [], json_encode($methodPlugin->getParameters()));
97	12		} catch (NetworkException $e) {
98			return NULL;
99			}
100
101	12		return $this->validateResponse($response);
102			}
103
104			/**
105			* Validate the response.
106			*
107			* @param \Psr\Http\Message\ResponseInterface $response
108			*
109			* @return \Exception\|ResponseInterface
110			*/
111	12		public function validateResponse(ResponseInterface $response) {
112	12		if (200 == $response->getStatusCode()) {
113	12		$body = json_decode((string) $response->getBody()->getContents(), TRUE);
114
115	12		if (isset($body['error']['code'])) {
116			switch ($body['error']['code']) {
117		View Code Duplication	case -32600:
			0 ignored issues – show Duplication introduced 2016-11-27 15:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118			throw new \InvalidArgumentException('Invalid Request: ' . $body['error']['message'], $body['error']['code']);
119			case -32601:
120			throw new \BadFunctionCallException('Procedure not found: ' . $body['error']['message'], $body['error']['code']);
121		View Code Duplication	case -32602:
			0 ignored issues – show Duplication introduced 2016-11-27 15:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122			throw new \InvalidArgumentException('Invalid arguments: ' . $body['error']['message'], $body['error']['code']);
123		View Code Duplication	case -32603:
			0 ignored issues – show Duplication introduced 2016-11-27 15:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124			throw new \RuntimeException('Internal Error: ' . $body['error']['message'], $body['error']['code']);
125		View Code Duplication	default:
			0 ignored issues – show Duplication introduced 2016-11-27 15:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126			throw new \RuntimeException('Invalid request/response: ' . $body['error']['message'], $body['error']['code']);
127			}
128			}
129	12		}
130
131	12		$response->getBody()->rewind();
132
133	12		return $response;
134			}
135
136			/**
137			* Get the logger.
138			*
139			* @return \Psr\Log\LoggerInterface
140			*/
141			public function getLogger() {
142			return $this->logger;
143			}
144
145			/**
146			* Set the logger.
147			*
148			* @param \Psr\Log\LoggerInterface $logger
149			*/
150			public function setLogger(LoggerInterface $logger) {
151			$this->logger = $logger;
152			}
153
154			/**
155			* Returns the UriFactory.
156			*
157			* @return \Http\Message\UriFactory
158			*/
159	15		public function getUriFactory() {
160	15		return $this->uriFactory;
161			}
162
163			/**
164			* @param \Http\Message\UriFactory $uriFactory
165			*/
166	15		public function setUriFactory(UriFactory $uriFactory) {
167	15		$this->uriFactory = $uriFactory;
168	15		}
169
170			}
171

drupol / yaroc

Push — master ( 73ec26...13e542 )

Client::validateResponse() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like