ObjectValue::hash() - Code Metrics - Inspection of "Add more predefined classes." - drupol/valuewrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Pol

created 2018-10-14 18:52 UTC

ObjectValue::hash() A

↳ Parent: ObjectValue

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php

declare(strict_types = 1);

namespace drupol\valuewrapper\Object;

use drupol\valuewrapper\AbstractValue;
use drupol\valuewrapper\Contract\Hashable;
use drupol\valuewrapper\ValueInterface;

/**
 * Class ObjectValue
 */
abstract class ObjectValue extends AbstractValue
{
    /**
     * {@inheritdoc}
     */
    public function hash(): string
    {
        if ($this->get() instanceof Hashable) {
            return $this->doHash(\gettype($this->get()) . \get_class($this->get()) . $this->get()->hash());
        }

        return $this->doHash(\gettype($this->get()) . \get_class($this->get()) . \spl_object_hash($this->get()));
    }

    /**
     * {@inheritdoc}
     */
    public function equals(ValueInterface $item, $strict = true): bool
    {
        return $this->hash() == $item->hash();
    }

    /**
     * {@inheritdoc}
     */
    public function serialize()
    {
        throw new \Exception('Not implemented');
    }

    /**
     * {@inheritdoc}
     */
    public function unserialize($serialized)
    {
        throw new \Exception('Not implemented');
    }

    /**
     * {@inheritdoc}
     */
    public function class()

    {
        return get_class($this->get());
class A {
    var $property;
}
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace drupol\valuewrapper\Object;
6
7		use drupol\valuewrapper\AbstractValue;
8		use drupol\valuewrapper\Contract\Hashable;
9		use drupol\valuewrapper\ValueInterface;
10
11		/**
12		* Class ObjectValue
13		*/
14		abstract class ObjectValue extends AbstractValue
15		{
16		/**
17		* {@inheritdoc}
18		*/
19		public function hash(): string
20		{
21		if ($this->get() instanceof Hashable) {
22		return $this->doHash(\gettype($this->get()) . \get_class($this->get()) . $this->get()->hash());
23		}
24
25		return $this->doHash(\gettype($this->get()) . \get_class($this->get()) . \spl_object_hash($this->get()));
26		}
27
28		/**
29		* {@inheritdoc}
30		*/
31	5	public function equals(ValueInterface $item, $strict = true): bool
32		{
33	5	return $this->hash() == $item->hash();
34		}
35
36		/**
37		* {@inheritdoc}
38		*/
39		public function serialize()
40		{
41		throw new \Exception('Not implemented');
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47		public function unserialize($serialized)
48		{
49		throw new \Exception('Not implemented');
50		}
51
52		/**
53		* {@inheritdoc}
54		*/
55		public function class()
		0 ignored issues – show Bug introduced 2018-10-14 18:58 UTC by Report Bug Copy Issue Report Possible parse error: non-abstract method defined as abstract Loading history...
56		{
57		return get_class($this->get());
		0 ignored issues – show Coding Style introduced 2018-10-14 18:58 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$this`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
58		}
59		}
60

drupol / valuewrapper

Pull Request — master (#2)

ObjectValue::hash() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like