ResourceValue::__construct() - Code Metrics - Inspection of "Initial commit." - drupol/valuewrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e33bed...05c971 )

by Pol

created 2018-10-11 14:32 UTC

ResourceValue::__construct() A

↳ Parent: ResourceValue

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	4
CRAP Score	2.1481

Importance

Changes

Metric	Value
dl	12
loc	12
ccs	4
cts	6
cp	0.6667
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.1481

<?php

namespace drupol\valuewrapper\Resource;

use drupol\valuewrapper\AbstractValue;

class ResourceValue extends AbstractValue
{
    /**
     * ResourceValue constructor.
     *
     * @param mixed $value
     */
    public function __construct($value)

    {
        // We cannot use type hint here because of this: https://3v4l.org/W9F7o
        if (false === \is_resource($value)) {
            throw new \TypeError(
                'Argument 1 passed to drupol\valuewrapper\Resource\ResourceValue::__construct()' .

                'must be of the type Resource, ' . gettype($value) . ' given.'
            );
        }

        parent::__construct($value);
    }

    /**
     * {@inheritdoc}
     */
    public function hash(): string
    {
        return $this->doHash(\spl_object_hash($this->get()));
    }

    /**
     * {@inheritdoc}
     */
    protected function doHash(string $string) : string
    {
        return \sha1(gettype($this->get()) . get_class($this->get()) . $string);
    }
}


1			<?php
2
3			namespace drupol\valuewrapper\Resource;
4
5			use drupol\valuewrapper\AbstractValue;
6
7			class ResourceValue extends AbstractValue
8			{
9			/**
10			* ResourceValue constructor.
11			*
12			* @param mixed $value
13			*/
14	1	View Code Duplication	public function __construct($value)
			0 ignored issues – show Duplication introduced 2018-10-11 14:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15			{
16			// We cannot use type hint here because of this: https://3v4l.org/W9F7o
17	1		if (false === \is_resource($value)) {
18			throw new \TypeError(
19			'Argument 1 passed to drupol\valuewrapper\Resource\ResourceValue::__construct()' .
			0 ignored issues – show Unused Code introduced 2018-10-11 14:34 UTC by Report Bug Copy Issue Report The call to `TypeError::__construct()` has too many arguments starting with `'Argument 1 passed to dr...ype($value) . ' given.'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
20			'must be of the type Resource, ' . gettype($value) . ' given.'
21			);
22			}
23
24	1		parent::__construct($value);
25	1		}
26
27			/**
28			* {@inheritdoc}
29			*/
30			public function hash(): string
31			{
32			return $this->doHash(\spl_object_hash($this->get()));
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			protected function doHash(string $string) : string
39			{
40			return \sha1(gettype($this->get()) . get_class($this->get()) . $string);
41			}
42			}
43

drupol / valuewrapper

Push — master ( e33bed...05c971 )

ResourceValue::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like