drupol\phpvfs\Command\Get::exec()

Complexity

Conditions	4
Paths	5

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function exec(FilesystemInterface $vfs, string $id): FilesystemNodeInterface
    {
        if (!Exist::exec($vfs, $id)) {
            throw new \Exception(\sprintf('Unknown path %s.', $id));
        }

        $path = Path::fromString($id);

        /** @var \drupol\phpvfs\Node\DirectoryInterface $cwd */
        $child = $path->isAbsolute() ?
            $vfs->getCwd()->root() :
            $vfs->getCwd();

        foreach ($path->getIterator() as $pathPart) {
            $child = $child->containsAttributeId($pathPart);

The method containsAttributeId() does not exist on drupol\phpvfs\Node\FilesystemNodeInterface. It seems like you code against a sub-type of drupol\phpvfs\Node\FilesystemNodeInterface such as drupol\phpvfs\Node\DirectoryInterface or drupol\phpvfs\Node\Directory.

        }

        return $child;

The expression return $child could return the type null which is incompatible with the type-hinted return drupol\phpvfs\Node\FilesystemNodeInterface. Consider adding an additional type-check to rule them out.

    }