drupol\phpvfs\Command\Get

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	exec()	0	18	4

<?php

declare(strict_types = 1);

namespace drupol\phpvfs\Command;

use drupol\phpvfs\Filesystem\FilesystemInterface;
use drupol\phpvfs\Node\FilesystemNodeInterface;
use drupol\phpvfs\Utils\Path;

class Get
{
    /**
     * @param \drupol\phpvfs\Filesystem\FilesystemInterface $vfs
     * @param string $id
     *
     *@throws \Exception
     *
     * @return \drupol\phpvfs\Node\FilesystemNodeInterface
     */
    public static function exec(FilesystemInterface $vfs, string $id): FilesystemNodeInterface
    {
        if (!Exist::exec($vfs, $id)) {
            throw new \Exception(\sprintf('Unknown path %s.', $id));
        }

        $path = Path::fromString($id);

        /** @var \drupol\phpvfs\Node\DirectoryInterface $cwd */
        $child = $path->isAbsolute() ?
            $vfs->getCwd()->root() :
            $vfs->getCwd();

        foreach ($path->getIterator() as $pathPart) {
            $child = $child->containsAttributeId($pathPart);

The method containsAttributeId() does not exist on drupol\phpvfs\Node\FilesystemNodeInterface. It seems like you code against a sub-type of drupol\phpvfs\Node\FilesystemNodeInterface such as drupol\phpvfs\Node\DirectoryInterface or drupol\phpvfs\Node\Directory.

        }

        return $child;

The expression return $child could return the type null which is incompatible with the type-hinted return drupol\phpvfs\Node\FilesystemNodeInterface. Consider adding an additional type-check to rule them out.

    }
}