drupol\phpvfs\Node\Vfs

Complexity

Total Complexity

11

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Test Coverage

Coverage

68%

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getPath()	0	11	2
A	add()	0	21	4
A	root()	0	9	2
A	contains()	0	10	3

<?php

declare(strict_types = 1);

namespace drupol\phpvfs\Node;

use drupol\phptree\Node\AttributeNode;
use drupol\phptree\Node\NodeInterface;
use drupol\phpvfs\Utils\Path;

/**
 * Class Vfs.
 */
abstract class Vfs extends AttributeNode implements VfsInterface
{
    /**
     * {@inheritdoc}
     *
     * @throws \Exception
     *
     * @return \drupol\phpvfs\Node\DirectoryInterface
     */
    public function add(NodeInterface ...$nodes): NodeInterface
    {
        /** @var \drupol\phpvfs\Node\VfsInterface $node */
        foreach ($nodes as $node) {
            if ($this->getAttribute('id') === $node->getAttribute('id')) {

The method getAttribute() does not exist on drupol\phptree\Node\NodeInterface. It seems like you code against a sub-type of drupol\phptree\Node\NodeInterface such as drupol\phptree\Node\AttributeNode or drupol\phptree\Node\AttributeNodeInterface or drupol\phptree\Node\AttributeNode.

                $this->add($node[0]->setParent(null));

                continue;
            }

            // If the $cwd contains the nodechild.
            if (null !== $child = $this->contains($node)) {
                $child->add($node[0]->setParent(null));

                continue;
            }

            parent::add($node->setParent(null));
        }

        return $this;

The expression return $this returns the type drupol\phpvfs\Node\Vfs which is incompatible with the documented return type drupol\phpvfs\Node\DirectoryInterface.

    }

    /**
     * {@inheritdoc}
     */
    public function getPath(): Path
    {
        $paths = [
            $this->getAttribute('id'),
        ];

        foreach ($this->getAncestors() as $ancestor) {
            \array_unshift($paths, $ancestor->getAttribute('id'));
        }

        return Path::fromString(\str_replace('//', '/', \implode('/', $paths)));
    }

    /**
     * {@inheritdoc}
     */
    public function root(): VfsInterface
    {
        $root = $this;

        foreach ($this->getAncestors() as $ancestor) {
            $root = $ancestor;
        }

        return $root;

The expression return $root could return the type drupol\phptree\Node\NodeInterface which includes types incompatible with the type-hinted return drupol\phpvfs\Node\VfsInterface. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param \drupol\phpvfs\Node\VfsInterface $node
     *
     * @return null|\drupol\phpvfs\Node\VfsInterface
     */
    protected function contains(VfsInterface $node): ?VfsInterface
    {
        /** @var \drupol\phpvfs\Node\VfsInterface $child */
        foreach ($this->children() as $child) {
            if ($node->getAttribute('id') === $child->getAttribute('id')) {

The method getAttribute() does not exist on ArrayObject.

                return $child;

The expression return $child returns the type ArrayObject which is incompatible with the type-hinted return drupol\phpvfs\Node\VfsInterface|null.

            }
        }

        return null;
    }
}