drupol\phpvfs\Command\Cd::exec()

Complexity

Conditions	5
Paths	8

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	5

Importance

Changes

0

<?php
    public static function exec(FilesystemInterface $vfs, string $id): DirectoryInterface
    {
        $path = Path::fromString($id);

        /** @var \drupol\phpvfs\Node\DirectoryInterface $cwd */
        $cwd = $path->isAbsolute() ?
            $vfs->getCwd()->root() :
            $vfs->getCwd();

        if ($path->isRoot()) {
            $vfs->setCwd($cwd);

            return $cwd;
        }

        foreach ($path->getIterator() as $pathPart) {
            if (null !== $child = $cwd->containsAttributeId($pathPart)) {
                $cwd = $child;
            } else {
                throw new \Exception('Unknown directory.');
            }
        }

        $vfs->setCwd($cwd);

        return $cwd;

The expression return $cwd could return the type drupol\phpvfs\Node\FilesystemNodeInterface which includes types incompatible with the type-hinted return drupol\phpvfs\Node\DirectoryInterface. Consider adding an additional type-check to rule them out.

    }