File::create() - Code Metrics - Inspection of "Add a File handler class to handler input/output i..." - drupol/phpvfs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 23d46a...ee003d )

by Pol

created 2019-07-01 11:26 UTC

File::create() A

↳ Parent: File

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	13
c	2
b	0
f	0
nc	4
nop	3
dl	0
loc	23
ccs	13
cts	13
cp	1
crap	4
rs	9.8333

<?php

declare(strict_types = 1);

namespace drupol\phpvfs\Node;

use drupol\phpvfs\Utils\Path;

/**
 * Class File.
 */
class File extends FilesystemNode implements FileInterface
{
    /**
     * File constructor.
     *
     * @param array $attributes
     */
    public function __construct(
        array $attributes = []
    ) {
        $attributes += [
            'content' => '',
            'position' => 0,
        ];

        parent::__construct($attributes, null);
    }

    /**
     * @param string $id
     * @param string $content
     * @param array $attributes
     *
     * @throws \Exception
     *
     * @return \drupol\phpvfs\Node\File
     */
    public static function create(string $id, string $content = '', array $attributes = [])
    {
        $path = Path::fromString($id);

        $dirname = $path->dirname();

        $basedir = null;
        if (!empty($dirname) && '.' !== $dirname) {
            $basedir = Directory::create($dirname);
        }

        $attributes = [
            'id' => $path->basename(),
            'content' => $content,
        ] + $attributes;

        $file = new self($attributes);

        if (null !== $basedir) {
            $basedir->add($file);
        }

        return $file;
    }

    /**
     * @return string
     */
    public function read(): string
    {
        return $this->getAttribute('content');

    }

    /**
     * @param string $data
     *
     * @return \drupol\phpvfs\Node\FileInterface
     */
    public function write(string $data): FileInterface
    {
        $this->setAttribute('content', $data);

        return $this;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace drupol\phpvfs\Node;
6
7		use drupol\phpvfs\Utils\Path;
8
9		/**
10		* Class File.
11		*/
12		class File extends FilesystemNode implements FileInterface
13		{
14		/**
15		* File constructor.
16		*
17		* @param array $attributes
18		*/
19	13	public function __construct(
20		array $attributes = []
21		) {
22		$attributes += [
23	13	'content' => '',
24		'position' => 0,
25		];
26
27	13	parent::__construct($attributes, null);
28	13	}
29
30		/**
31		* @param string $id
32		* @param string $content
33		* @param array $attributes
34		*
35		* @throws \Exception
36		*
37		* @return \drupol\phpvfs\Node\File
38		*/
39	12	public static function create(string $id, string $content = '', array $attributes = [])
40		{
41	12	$path = Path::fromString($id);
42
43	12	$dirname = $path->dirname();
44
45	12	$basedir = null;
46	12	if (!empty($dirname) && '.' !== $dirname) {
47	11	$basedir = Directory::create($dirname);
48		}
49
50		$attributes = [
51	12	'id' => $path->basename(),
52	12	'content' => $content,
53	12	] + $attributes;
54
55	12	$file = new self($attributes);
56
57	12	if (null !== $basedir) {
58	11	$basedir->add($file);
59		}
60
61	12	return $file;
62		}
63
64		/**
65		* @return string
66		*/
67	3	public function read(): string
68		{
69	3	return $this->getAttribute('content');
		0 ignored issues – show Bug Best Practice introduced 2019-07-01 11:29 UTC by Report Bug Copy Issue Report The expression `return $this->getAttribute('content')` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
70		}
71
72		/**
73		* @param string $data
74		*
75		* @return \drupol\phpvfs\Node\FileInterface
76		*/
77	1	public function write(string $data): FileInterface
78		{
79	1	$this->setAttribute('content', $data);
80
81	1	return $this;
82		}
83		}
84

drupol / phpvfs

Push — master ( 23d46a...ee003d )

File::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like