and let’s assume the following content of Bar.php:
// Bar.phpnamespaceOtherDir;useSomeDir\Foo;// This now conflicts the class OtherDir\Foo
If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the
same runtime, you will see a PHP error such as the following:
PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as OtherDir/Foo.php does not necessarily have to be loaded and the
error is only triggered if it is loaded before OtherDir/Bar.php, this problem
might go unnoticed for a while. In order to prevent this error from surfacing,
you must import the namespace with a different alias:
// Bar.phpnamespaceOtherDir;useSomeDir\FooasSomeDirFoo;// There is no conflict anymore.
Loading history...
6
7
trait NGramsTrait
8
{
9
10
/**
11
* @param \Generator $ngrams
12
* @param string $substring
13
*
14
* @return float|int
15
*/
16
2
public function frequency(\Generator $ngrams, $substring)
Avoid variables with short names like $n. Configured minimum length is 3.
Short variable names may make your code harder to understand. Variable names should
be self-descriptive. This check looks for variable names who are shorter than
a configured minimum.
Avoid variables with short names like $n. Configured minimum length is 3.
Short variable names may make your code harder to understand. Variable names should
be self-descriptive. This check looks for variable names who are shorter than
a configured minimum.
Loading history...
33
{
34
12
$ngrams = [];
35
36
12
if (is_string($data)) {
37
6
foreach ($this->doNgrams(str_split($data), $n, $cyclic) as $item) {
38
6
yield implode('', $item);
39
}
40
}
41
42
12
if (is_array($data)) {
43
8
foreach ($this->doNgrams($data, $n, $cyclic) as $item) {
44
8
yield $item;
45
}
46
}
47
48
12
return $ngrams;
49
}
50
51
/**
52
* @param $data
53
* @param $n
54
* @param $cyclic
55
*
56
* @return \Generator
57
*/
58
12
private function doNgrams($data, $n = 1, $cyclic = true)
Avoid variables with short names like $n. Configured minimum length is 3.
Short variable names may make your code harder to understand. Variable names should
be self-descriptive. This check looks for variable names who are shorter than
a configured minimum.
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: