drupol\phpermutations\Permutations

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	setSize()	0	3	1
A	getSize()	0	3	1
A	setElements()	0	5	1
A	getElements()	0	3	1
A	generator()	0	3	1
A	generate()	0	15	4
A	toArray()	0	9	2

<?php

namespace drupol\phpermutations;

/**
 * Class Permutations.
 *
 * @package drupol\phpermutations
 */
class Permutations {

  /**
   * @var mixed
   */
  protected $elements;

  /**
   * @var int
   */
  protected $size;

  /**
   * Permutations constructor.
   *
   * @param array $elements
   * @param int $size
   */
  public function __construct(array $elements, $size = NULL) {
    $this->setElements($elements);
    $size = $size ? $size : count($elements);
    $this->setSize($size);

    return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

  }

  /**
   * @param int $size
   */
  public function setSize($size) {
    $this->size = $size;
  }

  /**
   * @return int
   */
  public function getSize() {
    return (int) $this->size;
  }

  /**
   * @param array $elements
   *
   * @return $this
   */
  public function setElements(array $elements) {
    $this->elements = $elements;

    return $this;
  }

  /**
   * @return mixed
   */
  public function getElements() {
    return $this->elements;
  }

  /**
   * @return \Generator
   */
  public function generator() {
    return $this->generate($this->getElements(), $this->getSize());
  }

  /**
   * @param array $elements
   *
   * @return \Generator
   */
  protected function generate(array $elements, $length) {

The parameter $length is not used and could be removed.

    if (count($elements) <= 1) {
      yield $elements;
    } else {
      foreach ($this->generate(array_slice($elements, 1)) as $permutation) {

The call to generate() misses a required argument $length.

        foreach (range(0, count($elements) - 1) as $i) {
          yield array_merge(
            array_slice($permutation, 0, $i),
            [$elements[0]],
            array_slice($permutation, $i)
          );
        }
      }
    }
  }

  /**
   * @return array
   */
  public function toArray() {
    $results = array();

    foreach($this->generator() as $key => $value) {
      $results[$key] = $value;
    }

    return $results;
  }

}