drupol\phpermutations\Hilbert

Complexity

Total Complexity

26

Size/Duplication

Total Lines	185
Duplicated Lines	41.08 %

Coupling/Cohesion

Dependencies

0

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	setRecursion()	0	4	1
A	getRecursion()	0	3	1
A	point_to_hilbert()	12	12	4
B	hilbert_to_point()	25	25	5
A	xy2d()	14	14	4
B	d2xy()	25	25	5
A	test_pth()	0	11	4

<?php

namespace drupol\phpermutations;

/**
 * Class Hilbert.
 *
 * @package drupol\phpermutations
 */
class Hilbert {

The property $hilbert_map is not named in camelCase.

The property $rev_map is not named in camelCase.

  var $hilbert_map = array(

The visibility should be declared for property $hilbert_map.

    'a' => array(
      "0, 0" => array(0, 'd'),
      "0, 1" => array(1, 'a'),
      "1, 0" => array(3, 'b'),
      "1, 1" => array(2, 'a'),
    ),
    'b' => array(
      "0, 0" => array(2, 'b'),
      "0, 1" => array(1, 'b'),
      "1, 0" => array(3, 'a'),
      "1, 1" => array(0, 'c'),
    ),
    'c' => array(
      "0, 0" => array(2, 'c'),
      "0, 1" => array(3, 'd'),
      "1, 0" => array(1, 'c'),
      "1, 1" => array(0, 'b'),
    ),
    'd' => array(
      "0, 0" => array(0, 'a'),
      "0, 1" => array(3, 'c'),
      "1, 0" => array(1, 'd'),
      "1, 1" => array(2, 'd'),
    ),
  );

  var $rev_map = Array(

The visibility should be declared for property $rev_map.

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    'a' => Array(

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(3, 'd'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(1, 'a'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(0, 'a'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(2, 'c'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    ),
    'b' => Array(

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(0, 'c'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(2, 'b'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(3, 'b'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(1, 'd'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    ),
    'c' => Array(

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(0, 'b'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(1, 'c'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(3, 'c'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(2, 'a'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    ),
    'd' => Array(

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(3, 'a'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(2, 'd'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(0, 'd'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

      Array(1, 'b'),

As per coding-style, PHP keywords should be in lowercase; expected array, but found Array.

    ),
  );

  /**
   * @var int
   */
  protected $recursion;

  /**
   * Hilbert constructor.
   *
   * @param null $recursion
   */
  public function __construct($recursion = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    if (is_null($recursion)) {
      $recursion = 28;

Consider using a different name than the parameter $recursion. This often makes code more readable.

    }
    $this->setRecursion($recursion);
  }

  /**
   * @param $recursion
   *
   * @return $this
   */
  public function setRecursion($recursion) {
    $this->recursion = $recursion;
    return $this;
  }

  /**
   * @return int
   */
  public function getRecursion() {
    return $this->recursion;
  }


  function point_to_hilbert($x, $y, $order = 16, $map = "hilbert_map_1", $mode = "hilbert") {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

Avoid variables with short names like $x. Configured minimum length is 3.

Avoid variables with short names like $y. Configured minimum length is 3.

The method point_to_hilbert is not named in camelCase.

The variable $current_square is not named in camelCase.

The variable $quad_x is not named in camelCase.

The variable $quad_y is not named in camelCase.

The variable $quad_position is not named in camelCase.

Method name "Hilbert::point_to_hilbert" is not in camel caps format

It is recommend to declare an explicit visibility for point_to_hilbert.

    $current_square = 'a';
    $position = 0;
    foreach (range($order - 1, 0, -1) as $i) {
      $position <<= 2;
      $quad_x = $x & (1 << $i) ? 1 : 0;
      $quad_y = $y & (1 << $i) ? 1 : 0;
      list($quad_position, $current_square) = $this->{$map}[$current_square]["$quad_x, $quad_y"];
      $position |= $quad_position;
    }
    return $position;
  }

  function hilbert_to_point($hilbert, $order) {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

The method hilbert_to_point is not named in camelCase.

The variable $current_square is not named in camelCase.

Method name "Hilbert::hilbert_to_point" is not in camel caps format

It is recommend to declare an explicit visibility for hilbert_to_point.

    $current_square = "a";
    $amount = 1 << $order - 1;
    $x = $y = 0;

Avoid variables with short names like $x. Configured minimum length is 3.

Avoid variables with short names like $y. Configured minimum length is 3.

    for ($i = 2 * $order; $i > 0; $i -= 2) {
      list ($position, $current_square) = $this->rev_map[$current_square][$hilbert >> $i - 2];
      switch ($position) {
        case 1:
          $x += $amount;
          break;
        case 2:
          $y += $amount;
          break;
        case 3:
          $y += $amount;
          $x += $amount;
          break;
        default:
          break;
      }
      $amount /= 2;
      $hilbert &= (1 << ($i - 2)) - 1;
    }
    return [$x, $y];
  }


  function xy2d($x, $y, $order = 16) {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

Avoid variables with short names like $x. Configured minimum length is 3.

Avoid variables with short names like $y. Configured minimum length is 3.

The variable $current_square is not named in camelCase.

The variable $quad_x is not named in camelCase.

The variable $quad_y is not named in camelCase.

The variable $quad_position is not named in camelCase.

It is recommend to declare an explicit visibility for xy2d.

    $current_square = 'a';
    $position = 0;

    foreach (range($order - 1, 0, -1) as $i) {
      $position <<= 2;
      $quad_x = $x & (1 << $i) ? 1 : 0;
      $quad_y = $y & (1 << $i) ? 1 : 0;
      list($quad_position, $current_square) = $this->hilbert_map[$current_square]["$quad_x, $quad_y"];
      $position |= $quad_position;
    }

    return $position;
  }

  function d2xy($hilbert, $order = 16) {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

The variable $current_square is not named in camelCase.

It is recommend to declare an explicit visibility for d2xy.

    $current_square = "a";
    $amount = 1 << $order - 1;
    $x = $y = 0;

Avoid variables with short names like $x. Configured minimum length is 3.

Avoid variables with short names like $y. Configured minimum length is 3.

    for ($i = 2 * $order; $i > 0; $i -= 2) {
      list ($position, $current_square) = $this->rev_map[$current_square][$hilbert >> $i - 2];
      switch ($position) {
        case 1:
          $x += $amount;
          break;
        case 2:
          $y += $amount;
          break;
        case 3:
          $y += $amount;
          $x += $amount;
          break;
        default:
          break;
      }
      $amount /= 2;
      $hilbert &= (1 << ($i - 2)) - 1;
    }
    return [$x, $y];
  }

  function test_pth() {

It is generally recommended to explicitly declare the visibility for methods.

The method test_pth is not named in camelCase.

Method name "Hilbert::test_pth" is not in camel caps format

It is recommend to declare an explicit visibility for test_pth.

    foreach (range(7, 0, -1) as $x) {
      foreach (range(7, 0, -1) as $y) {
        $sort[] = $points["$x, $y"] = $this->point_to_hilbert($x, $y, 3);
      }
    }
    array_multisort($points, $sort);
    foreach ($points as $k => $v) {
      echo $k . "\n";
    }
  }

}