Combinations::nextHelper() - Code Metrics - Inspection of "Interfaces cleanup" - drupol/phpermutations - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Pol

created 2018-04-20 08:46 UTC

Combinations::nextHelper() B

↳ Parent: Combinations

Complexity

Conditions	5
Paths	6

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	10
cts	10
cp	1
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	6
nop	0
crap	5

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;
use drupol\phpermutations\IteratorInterface;

/**
 * Class Combinations.
 */
class Combinations extends Combinatorics implements IteratorInterface
{
    /**
     * The values.
     *
     * @var array
     */
    protected $c = [];


    /**
     * The key.
     *
     * @var int
     */
    protected $key = 0;

    /**
     * Combinations constructor.
     *
     * @param array    $dataset
     *                          The dataset
     * @param int|null $length
     *                          The length
     */
    public function __construct(array $dataset = [], $length = null)
    {
        parent::__construct(array_values($dataset), $length);
        $this->rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        $r = [];


        for ($i = 0; $i < $this->length; ++$i) {
            $r[] = $this->dataset[$this->c[$i]];
        }

        return $r;
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        if ($this->nextHelper()) {
            ++$this->key;
        } else {
            $this->key = -1;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        $this->c = range(0, $this->length);
        $this->key = 0;
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        return $this->key >= 0;
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        return $this->fact(count($this->getDataset())) /
          ($this->fact($this->getLength()) * $this->fact(count($this->getDataset()) - $this->getLength()));
    }

    /**
     * Custom next() callback.
     *
     * @return bool
     *              Return true or false
     */
    protected function nextHelper()
    {
        $i = $this->length - 1;
        while ($i >= 0 && $this->c[$i] === $this->datasetCount - $this->length + $i) {
            --$i;
        }

        if ($i < 0) {
            return false;
        }

        ++$this->c[$i];
        while ($i++ < $this->length - 1) {
            $this->c[$i] = $this->c[$i - 1] + 1;
        }

        return true;
    }
}


1		<?php
2
3		namespace drupol\phpermutations\Iterators;
4
5		use drupol\phpermutations\Combinatorics;
6		use drupol\phpermutations\IteratorInterface;
7
8		/**
9		* Class Combinations.
10		*/
11		class Combinations extends Combinatorics implements IteratorInterface
12		{
13		/**
14		* The values.
15		*
16		* @var array
17		*/
18		protected $c = [];
		0 ignored issues – show Comprehensibility introduced 2017-08-15 18:29 UTC by Report Bug Copy Issue Report Avoid variables with short names like $c. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
19
20		/**
21		* The key.
22		*
23		* @var int
24		*/
25		protected $key = 0;
26
27		/**
28		* Combinations constructor.
29		*
30		* @param array $dataset
31		* The dataset
32		* @param int\|null $length
33		* The length
34		*/
35	10	public function __construct(array $dataset = [], $length = null)
36		{
37	10	parent::__construct(array_values($dataset), $length);
38	10	$this->rewind();
39	10	}
40
41		/**
42		* {@inheritdoc}
43		*/
44	4	public function current()
45		{
46	4	$r = [];
		0 ignored issues – show Comprehensibility introduced 2017-08-15 18:29 UTC by Report Bug Copy Issue Report Avoid variables with short names like $r. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
47
48	4	for ($i = 0; $i < $this->length; ++$i) {
49	4	$r[] = $this->dataset[$this->c[$i]];
50		}
51
52	4	return $r;
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58	4	public function next()
59		{
60	4	if ($this->nextHelper()) {
61	3	++$this->key;
62		} else {
63	4	$this->key = -1;
64		}
65	4	}
66
67		/**
68		* {@inheritdoc}
69		*/
70	10	public function rewind()
71		{
72	10	$this->c = range(0, $this->length);
73	10	$this->key = 0;
74	10	}
75
76		/**
77		* {@inheritdoc}
78		*/
79	4	public function valid()
80		{
81	4	return $this->key >= 0;
82		}
83
84		/**
85		* {@inheritdoc}
86		*/
87	10	public function count()
88		{
89	10	return $this->fact(count($this->getDataset())) /
90	10	($this->fact($this->getLength()) * $this->fact(count($this->getDataset()) - $this->getLength()));
91		}
92
93		/**
94		* Custom next() callback.
95		*
96		* @return bool
97		* Return true or false
98		*/
99	4	protected function nextHelper()
100		{
101	4	$i = $this->length - 1;
102	4	while ($i >= 0 && $this->c[$i] === $this->datasetCount - $this->length + $i) {
103	4	--$i;
104		}
105
106	4	if ($i < 0) {
107	4	return false;
108		}
109
110	3	++$this->c[$i];
111	3	while ($i++ < $this->length - 1) {
112	3	$this->c[$i] = $this->c[$i - 1] + 1;
113		}
114
115	3	return true;
116		}
117		}
118

drupol / phpermutations

Pull Request — master (#9)

Combinations::nextHelper() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like