drupol\phpermutations\Iterators\Combinations

Complexity

Total Complexity

16

Size/Duplication

Total Lines	113
Duplicated Lines	6.19 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

94.87%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	key()	0	3	1
A	rewind()	0	4	1
A	valid()	0	3	1
A	count()	0	3	1
A	current()	0	7	2
A	next()	0	8	2
B	_next()	0	15	5
A	toArray()	7	9	2

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;

/**
 * Class Combinations.
 *
 * @package drupol\phpermutations\Iterators
 */
class Combinations extends Combinatorics implements \Iterator {

  /**
   * @var array
   */
  protected $c = array();

Avoid variables with short names like $c. Configured minimum length is 3.

  /**
   * @var int
   */
  protected $count = 0;

  /**
   * @var int
   */
  protected $pos = 0;

  /**
   * Combinations constructor.
   *
   * @param array $dataset
   * @param null $length
   */
  public function __construct(array $dataset = array(), $length = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    parent::__construct($dataset, $length);
    $this->rewind();
  }

  /**
   * @return int
   */
  public function key() {
    return $this->pos;
  }

  /**
   * @return array
   */
  public function current() {
    $r = array();

Avoid variables with short names like $r. Configured minimum length is 3.

    for ($i = 0; $i < $this->length; $i++) {
      $r[] = $this->dataset[$this->c[$i]];
    }
    return $r;
  }

  /**
   *
   */
  public function next() {
    if ($this->_next()) {
      $this->pos++;
    }
    else {
      $this->pos = -1;
    }
  }

  /**
   *
   */
  public function rewind() {
    $this->c = range(0, $this->length);
    $this->pos = 0;
  }

  /**
   * @return bool
   */
  public function valid() {
    return $this->pos >= 0;
  }

  /**
   * @return bool
   */
  protected function _next() {

The method _next is not named in camelCase.

    $i = $this->length - 1;
    while ($i >= 0 && $this->c[$i] == $this->datasetCount - $this->length + $i) {
      $i--;
    }
    if ($i < 0) {
      return FALSE;

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

    }
    $this->c[$i]++;
    while ($i++ < $this->length - 1) {
      $this->c[$i] = $this->c[$i - 1] + 1;
    }

    return TRUE;

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

  }

  /**
   * @return array
   */
  public function toArray() {

This method seems to be duplicated in your project.

    $data = [];

    for ($this->rewind(); $this->valid(); $this->next()) {
      $data[] = $this->current();
    }

    return $data;
  }

  /**
   * @return int
   */
  public function count() {
    return $this->fact(count($this->getDataset())) / $this->fact($this->getLength());
  }

}