drupol\phpermutations\Iterators\Prime

Complexity

Total Complexity

18

Size/Duplication

Total Lines	135
Duplicated Lines	3.7 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	current()	0	3	1
A	next()	0	11	3
A	key()	0	3	1
A	valid()	0	3	1
A	rewind()	0	3	1
A	count()	5	11	3
A	toArray()	0	9	2
A	isPrimeNumber()	0	13	3
A	setMaxLimit()	0	3	1
A	getMaxLimit()	0	3	1

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;

/**
 * Class Prime.
 *
 * @package drupol\phpermutations\Iterators
 */
class Prime extends Combinatorics implements \Iterator {

  /**
   * @var int
   */
  protected $max;

  /**
   * @var int
   */
  protected $key;

  /**
   * @var int
   */
  protected $count = 1;

  /**
   * @var int
   */
  protected $current = 2;

  /**
   * Prime constructor.
   */
  public function __construct() {
    $this->setMaxLimit(PHP_INT_MAX);
  }

  /**
   * @inheritdoc
   */
  public function current() {
    return $this->current;
  }

  /**
   * @inheritdoc
   */
  public function next() {
    ++$this->key;
    for($i = $this->key; $i < $this->getMaxLimit(); $i++) {

Expected 1 space after FOR keyword; 0 found

      if ($this->isPrimeNumber($i)) {
        $this->key = $i;
        $this->current = $i;
        $this->count++;
        break;
      }
    }
  }

  /**
   * @inheritdoc
   */
  public function key() {
    return $this->key;
  }

  /**
   * @inheritdoc
   */
  public function valid() {
    return ($this->current == $this->key());
  }

  /**
   * @inheritdoc
   */
  public function rewind() {
    $this->key = 2;
  }

  /**
   * @return int
   */
  public function count() {
    $this->count = 0;

    for ($j = 2; $j <= $this->getMaxLimit(); $j++) {

This code seems to be duplicated across your project.

      if ($this->isPrimeNumber($j)) {
        $this->count++;
      }
    }

    return $this->count;
  }

  /**
   * @return array
   */
  public function toArray() {
    $data = array();

    for ($this->rewind(); $this->valid(); $this->next()) {
      $data[] = $this->current();
    }

    return $data;
  }


  /**
   * @param $number
   *
   * @return bool
   */
  protected function isPrimeNumber($number) {
    $n = abs($number);

Avoid variables with short names like $n. Configured minimum length is 3.

    $i = 2;

    while ($i <= sqrt($n)) {
      if ($n % $i == 0) {
        return FALSE;

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

      }
      $i++;
    }

    return TRUE;

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

  }

  /**
   * @param int $max
   */
  public function setMaxLimit($max) {
    $this->max = $max;
  }

  /**
   * @return int
   */
  public function getMaxLimit() {
    return intval($this->max);
  }

}