drupol\phpermutations\Permutations

Complexity

Total Complexity

14

Size/Duplication

Total Lines	114
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

100%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	count()	0	3	1
A	setLength()	0	3	1
A	getLength()	0	3	1
A	setDataset()	0	5	1
A	getDataset()	0	3	1
A	generator()	0	3	1
A	permute()	0	21	4
A	toArray()	0	9	2

<?php

namespace drupol\phpermutations;

/**
 * Class Permutations.
 *
 * @package drupol\phpermutations
 */
class Permutations implements \Countable {

  /**
   * @var mixed
   */
  protected $dataset;

  /**
   * @var int
   */
  protected $length;

  /**
   * Permutations constructor.
   *
   * @param array $dataset
   * @param int $length

Should the type for parameter $length not be integer|null?

   */
  public function __construct(array $dataset = array(), $length = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    $this->setDataset($dataset);
    $length = ($length > $this->count()) ? $this->count() : $length;

Consider using a different name than the parameter $length. This often makes code more readable.

    $this->setLength($length);

    return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

  }

  /**
   * @return int
   */
  public function count() {
    return count($this->getDataset());
  }

  /**
   * @param int $length
   */
  public function setLength($length) {
    $this->length = $length;
  }

  /**
   * @return int
   */
  public function getLength() {
    return (int) $this->length;
  }

  /**
   * @param array $dataset
   *
   * @return $this
   */
  public function setDataset(array $dataset = array()) {
    $this->dataset = $dataset;

    return $this;
  }

  /**
   * @return mixed
   */
  public function getDataset() {
    return $this->dataset;
  }

  /**
   * @return array
   */
  public function generator() {
    return $this->permute($this->getDataset(), array());
  }

  /**
   * @param $items
   * @param array $perms
   *
   * @return array
   */
  protected function permute($items, $perms = array( )) {
    $result = array();

    foreach (new Combinations($items, $this->getLength()) as $dataset) {
      if (empty($dataset)) {
        $return = array($perms);
      }  else {
        $return = array();
        for ($i = count($dataset) - 1; $i >= 0; --$i) {
          $newitems = $dataset;
          $newperms = $perms;
          list($foo) = array_splice($newitems, $i, 1);
          array_unshift($newperms, $foo);
          $return = array_merge($return, $this->permute($newitems, $newperms));
        }
      }
      $result = array_merge($result, $return);
    }

    return $result;
  }

  /**
   * @return array
   */
  public function toArray() {
    $results = array();

    foreach($this->generator() as $value) {

Expected 1 space after FOREACH keyword; 0 found

      $results[] = $value;
    }

    return $results;
  }

}