drupol\phpermutations\Permutations

Complexity

Total Complexity

9

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

2

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	count()	0	3	1
A	generator()	0	3	1
B	permute()	0	22	4
A	toArray()	0	9	2

<?php

namespace drupol\phpermutations;

/**
 * Class Permutations.
 *
 * @package drupol\phpermutations
 */
class Permutations extends Combinatorics {

  /**
   * Permutations constructor.
   *
   * @param array $dataset
   * @param int $length

Should the type for parameter $length not be integer|null?

   */
  public function __construct(array $dataset = array(), $length = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    parent::__construct($dataset, $length);

It seems like $length defined by parameter $length on line 18 can also be of type integer; however, drupol\phpermutations\Combinatorics::__construct() does only seem to accept null, maybe add an additional type check?

  }

  /**
   * @return int
   */
  public function count() {
    return $this->fact(count($this->getDataset()))/$this->fact(count($this->getDataset()) - $this->getLength());
  }

  /**
   * @return array
   */
  public function generator() {
    return $this->permute($this->getDataset(), array());
  }

  /**
   * @param $items
   * @param array $perms
   *
   * @return array
   */
  protected function permute($items, $perms = array( )) {
    $result = array();

    foreach (new Combinations($items, $this->getLength()) as $dataset) {
      if (empty($dataset)) {
        $return = array($perms);
      }  else {
        $return = array();
        $datasetCount = count($dataset) - 1;
        for ($i = $datasetCount; $i >= 0; --$i) {
          $newitems = $dataset;
          $newperms = $perms;
          list($foo) = array_splice($newitems, $i, 1);
          array_unshift($newperms, $foo);
          $return = array_merge($return, $this->permute($newitems, $newperms));
        }
      }
      $result = array_merge($result, $return);
    }

    return $result;
  }

  /**
   * @return array
   */
  public function toArray() {
    $results = array();

    foreach($this->generator() as $value) {

Expected 1 space after FOREACH keyword; 0 found

      $results[] = $value;
    }

    return $results;
  }

}