drupol\phpermutations\Combinatorics

Complexity

Total Complexity

9

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

0

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	setLength()	0	6	3
A	getLength()	0	3	1
A	setDataset()	0	5	1
A	getDataset()	0	3	1
A	fact()	0	3	2

<?php

namespace drupol\phpermutations;

abstract class Combinatorics implements \Countable {

  /**
   * @var array
   */
  protected $dataset;

  /**
   * @var int
   */
  protected $datasetCount;

  /**
   * @var int
   */
  protected $length;

  /**
   * Combinatorics constructor.
   *
   * @param array $dataset
   * @param null $length
   */
  public function __construct(array $dataset = array(), $length = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    $this->setDataset($dataset);
    $this->datasetCount = count($this->dataset);
    $this->setLength($length);
  }

  /**
   * @param int $length

Should the type for parameter $length not be integer|null?

   *
   * @return $this
   */
  public function setLength($length = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    $length = is_null($length) ? $this->datasetCount : $length;

Consider using a different name than the parameter $length. This often makes code more readable.

    $this->length = ($length > $this->datasetCount) ? $this->datasetCount : $length;

    return $this;
  }

  /**
   * @return int
   */
  public function getLength() {
    return (int) $this->length;
  }

  /**
   * @param array $dataset
   *
   * @return $this
   */
  public function setDataset(array $dataset = array()) {
    $this->dataset = $dataset;

    return $this;
  }

  /**
   * @return mixed
   */
  public function getDataset() {
    return $this->dataset;
  }

  /**
   * @param $n
   * @param int $total
   *
   * @return int
   */
  protected function fact($n, $total = 1) {

Avoid variables with short names like $n. Configured minimum length is 3.

      return ($n < 2) ? $total : $this->fact($n-1, $total * $n);
  }

}