drupol\phpermutations\Iterators\Combinations

Complexity

Total Complexity

16

Size/Duplication

Total Lines	129
Duplicated Lines	5.43 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

95%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	current()	0	9	2
A	next()	0	8	2
A	toArray()	7	10	2
A	__construct()	0	5	1
A	key()	0	4	1
A	rewind()	0	5	1
A	valid()	0	4	1
A	count()	0	5	1
B	nextHelper()	0	16	5

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;

/**
 * Class Combinations.
 */
class Combinations extends Combinatorics implements \Iterator
{
    /**
     * The values.
     *
     * @var array
     */
    protected $c = [];

Avoid variables with short names like $c. Configured minimum length is 3.

    /**
     * The key.
     *
     * @var int
     */
    protected $key = 0;

    /**
     * Combinations constructor.
     *
     * @param array    $dataset
     *                          The dataset
     * @param int|null $length
     *                          The length
     */
    public function __construct(array $dataset = [], $length = null)
    {
        parent::__construct(array_values($dataset), $length);
        $this->rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        return $this->key;
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        $r = [];

Avoid variables with short names like $r. Configured minimum length is 3.

        for ($i = 0; $i < $this->length; ++$i) {
            $r[] = $this->dataset[$this->c[$i]];
        }

        return $r;
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        if ($this->nextHelper()) {
            ++$this->key;
        } else {
            $this->key = -1;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        $this->c = range(0, $this->length);
        $this->key = 0;
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        return $this->key >= 0;
    }

    /**
     * Convert the iterator into an array.
     *
     * @return array
     *               The elements
     */
    public function toArray()

This method seems to be duplicated in your project.

    {
        $data = [];

        for ($this->rewind(); $this->valid(); $this->next()) {
            $data[] = $this->current();
        }

        return $data;
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        return $this->fact(count($this->getDataset())) /
          ($this->fact($this->getLength()) * $this->fact(count($this->getDataset()) - $this->getLength()));
    }

    /**
     * Custom next() callback.
     *
     * @return bool
     *              Return true or false
     */
    protected function nextHelper()
    {
        $i = $this->length - 1;
        while ($i >= 0 && $this->c[$i] === $this->datasetCount - $this->length + $i) {
            --$i;
        }
        if ($i < 0) {
            return false;
        }
        ++$this->c[$i];
        while ($i++ < $this->length - 1) {
            $this->c[$i] = $this->c[$i - 1] + 1;
        }

        return true;
    }
}