drupol\phpartition\SubsetContainer

Complexity

Total Complexity

14

Size/Duplication

Total Lines	97
Duplicated Lines	19.59 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	addItemsToSubset()	0	5	2
A	compare()	0	9	3
A	setPartition()	0	7	2
A	addItemToSubset()	0	6	1
A	getSubsets()	10	10	2
A	getSubsetsAndItemsAsArray()	9	9	2
A	setAlgo()	0	3	1
A	getAlgo()	0	3	1

<?php

namespace drupol\phpartition;

class SubsetContainer extends \SplHeap {

  /**
   * @var BasePartitionAlgorithm
   */
  protected $algo;

  /**
   * Override compare method.
   *
   * @param Subset $a
   * @param Subset $b
   *
   * @return int
   */
  public function compare($a, $b) {

Avoid variables with short names like $a. Configured minimum length is 3.

Avoid variables with short names like $b. Configured minimum length is 3.

    $al = $a->getAlgo()->getSubsetWeight($a);

Avoid variables with short names like $al. Configured minimum length is 3.

The method getSubsetWeight() does not seem to exist on object<drupol\phpartition\BasePartitionAlgorithm>.

    $bl = $b->getAlgo()->getSubsetWeight($b);

Avoid variables with short names like $bl. Configured minimum length is 3.

The method getSubsetWeight() does not seem to exist on object<drupol\phpartition\BasePartitionAlgorithm>.

    if ($al == $bl) {
      return 0;
    }
    return ($al > $bl) ? -1 : +1;
  }

  /**
   * @param $partition
   */
  public function setPartition($partition) {
    for($i=0; $i<$partition; $i++) {

Expected 1 space after FOR keyword; 0 found

      $subset = new Subset();
      $subset->setAlgo($this->getAlgo());
      $this->insert($subset);
    }
  }

  /**
   * @param SubsetItem[] $items
   */
  public function addItemsToSubset(array $items = array()) {
    foreach ($items as $item) {
      $this->addItemToSubset($item);
    }
  }

  /**
   * @param \drupol\phpartition\SubsetItem $item
   */
  public function addItemToSubset(SubsetItem $item) {
    $this->top();
    $subset = $this->extract();
    $subset->addItem($item);
    $this->insert($subset);
  }

  /**
   * @return Subset[]
   */
  public function getSubsets() {

This method seems to be duplicated in your project.

    $data = array();
    $clone = clone $this;

    for($clone->top(); $clone->valid(); $clone->next()) {

Expected 1 space after FOR keyword; 0 found

      $data[] = $clone->current();
    }

    return $data;
  }

  /**
   * @return array
   */
  public function getSubsetsAndItemsAsArray() {

This method seems to be duplicated in your project.

    $data = array();

    foreach ($this->getSubsets() as $subset) {
      $data[] = $subset->getRawItems();
      }

Closing brace indented incorrectly; expected 4 spaces, found 6

    return array_values(array_filter($data));
  }

  /**
   * @param \drupol\phpartition\BasePartitionAlgorithm $algo
   */
  public function setAlgo(BasePartitionAlgorithm $algo) {
    $this->algo = $algo;
  }

  /**
   * @return BasePartitionAlgorithm
   */
  public function getAlgo() {
    return $this->algo;
  }

}