drupol\phpartition\GreedyAltAlt

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fillPartitions()	0	32	5
A	findOptimalItemKey()	0	11	2

<?php

declare(strict_types = 1);

namespace drupol\phpartition;

use drupol\phpartition\Partition\Partition;
use drupol\phpartition\Partitions\Partitions;

/**
 * Class GreedyAltAlt.
 */
class GreedyAltAlt extends Partitioner
{
    /**
     * {@inheritdoc}
     */
    protected function fillPartitions(Partitions $partitions, Partition $dataset, int $chunks): void
    {
        $partitionItemFactory = $this->getPartitionItemFactory();

        // Greedy needs a dataset sorted DESC.
        $dataset->uasort(static function ($a, $b) use ($partitionItemFactory) {
            $left = $partitionItemFactory::create($a);
            $right = $partitionItemFactory::create($b);

            return $right->getWeight() <=> $left->getWeight();
        });

        $partitionsArray = [];

        for ($p = $chunks; 1 < $p; --$p) {
            $partition = new Partition();
            $best = $dataset->getWeight() / $chunks;

            while ($partition->getWeight() < $best && !empty($dataset)) {
                $key = $this->findOptimalItemKey($partition, $dataset, $best);
                $partition->append($dataset[$key]);
                unset($dataset[$key]);
                $dataset->exchangeArray(\array_values($dataset->getArrayCopy()));
            }

            $partitionsArray[] = $partition;
        }

        $partitionsArray[] = $dataset;

        foreach ($partitionsArray as $key => $subset) {
            $partitions->partition($key)->exchangeArray($subset);
        }
    }

    /**
     * @param \drupol\phpartition\Partition\Partition $partition
     * @param \drupol\phpartition\Partition\Partition $dataset
     * @param float $best
     *
     * @return null|false|int|string
     */
    private function findOptimalItemKey(Partition $partition, Partition $dataset, $best)

The parameter $best is not used and could be removed.

    {
        if (0 === $partition->count()) {
            \reset($dataset);

$dataset of type drupol\phpartition\Partition\Partition is incompatible with the type array expected by parameter $array of reset().

            return \key($dataset);
        }

        \end($dataset);

$dataset of type drupol\phpartition\Partition\Partition is incompatible with the type array expected by parameter $array of end().

        return \key($dataset);
    }
}