drupol\phpartition\PartitionItem

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

0

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getValue()	0	7	2
A	getItem()	0	3	1

<?php

namespace drupol\phpartition;

/**
 * Class PartitionItem.
 *
 * @package drupol\phpartition
 */
class PartitionItem implements PartitionItemInterface {

  protected $item;
  protected $valueCallable;

  /**
   * PartitionItem constructor.
   *
   * @param mixed $item
   *   The item.
   * @param callable $valueCallable

Should the type for parameter $valueCallable not be null|callable? Also, consider making the array more specific, something like array<String>, or String[].

   *   The callable that will get it's value.
   */
  public function __construct($item, callable $valueCallable = NULL) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

    $this->item = $item;
    $this->valueCallable = $valueCallable;
  }

  /**
   * {@inheritdoc}
   */
  public function getValue() {
    if (!is_null($this->valueCallable)) {
      return call_user_func($this->valueCallable, $this->item);
    }

    return $this->item;
  }

  /**
   * {@inheritdoc}
   */
  public function getItem() {
    return $this->item;
  }

}