drupol\phpartition\Algorithm\BruteForce

Complexity

Total Complexity

9

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

6

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
C	getResult()	0	39	7
A	getSubsetWeight()	0	9	2

<?php

namespace drupol\phpartition\Algorithm;

use drupol\phpartition\BasePartitionAlgorithm;
use drupol\phpartition\PartitionAlgorithmInterface;
use drupol\phpartition\Subset;
use Math\Combinatorics\Permutation;

/**
 * Class BruteForce.
 *
 * @package drupol\phpartition\Algorithm
 */
class BruteForce extends BasePartitionAlgorithm implements PartitionAlgorithmInterface {

  /**
   * @return array
   */
  public function getResult() {

The variable $partition_size is not named in camelCase.

The variable $good_subset is not named in camelCase.

The variable $max_size is not named in camelCase.

    $permutation = new Permutation();
    $this->dataset->sortByValue('ASC');

    $partition_size = ($this->getPartition() > $this->dataset->count()) ? $this->dataset->count() : $this->getPartition();

    for ($p=$partition_size; $p > 1; $p--) {
      $best = $this->dataset->getSum();
      $target = ($best - ($best % $p))/ $p;
      $good_subset = array();
      $max_size = floor($this->dataset->count() / $p);

      for ($i = 1; $i <= $max_size; $i++) {
        foreach ($permutation->getPermutations($this->dataset->getItems(), $i) as $subset) {
          $x = 0;
          foreach ($subset as $item) {
            $x += $item->getValue();
            if (abs($x - $target) - abs($best - $target) < 0) {
              $best = $x;
              $good_subset = $subset;
            }
          }
        }
      }

      $subset = new Subset();
      $subset->setAlgo($this);
      $subset->addItems($good_subset);
      $this->getSubsetContainer()->insert($subset);
      $this->dataset->deleteItems($good_subset);
    }

    $subset = new Subset();
    $subset->setAlgo($this);
    $subset->addItems($this->dataset->getItems());
    $this->getSubsetContainer()->insert($subset);

    return $this->getSubsetContainer()->getSubsetsAndItemsAsArray();
  }

  /**
   * @param \drupol\phpartition\Subset $subset
   *
   * @return int|mixed
   */
  public function getSubsetWeight(Subset $subset) {
    $sum = 0;

    foreach($subset->getItems() as $item) {

Expected 1 space after FOREACH keyword; 0 found

      $sum += $item->getValue();
    }

    return $sum;
  }

}