drupal-media / entity_browser

src/EntityBrowserInterface.php

Doc Comments -4 removed lines

@@ -53,8 +53,6 @@ 
   /**
    * Sets the id of the widget selector plugin.
    *
-   * @param string $display
-   *   The id of the widget selector plugin.
    *
    * @return \Drupal\entity_browser\EntityBrowserInterface
    *   The class instance this method is called on.
@@ -64,8 +62,6 @@ 
   /**
    * Sets the id of the selection display plugin.
    *
-   * @param string $display
-   *   The id of the selection display plugin.
    *
    * @return \Drupal\entity_browser\EntityBrowserInterface
    *   The class instance this method is called on.

src/Entity/EntityBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -385,7 +385,7 @@
           '_title_callback' => 'Drupal\entity_browser\Controllers\EntityBrowserFormController::title',
           'entity_browser_id' => $this->id(),
         ],
-        ['_permission' => 'access ' . $this->id() . ' entity browser pages'],
+        ['_permission' => 'access '.$this->id().' entity browser pages'],
         ['_admin_route' => \Drupal::config('node.settings')->get('use_admin_theme')]
       );
     }

src/Element/EntityBrowserElement.php

Braces +1 added lines, -2 removed lines

@@ -136,8 +136,7 @@
     /** @var \Drupal\entity_browser\EntityBrowserInterface $entity_browser */
     if (is_string($element['#entity_browser'])) {
       $entity_browser = EntityBrowser::load($element['#entity_browser']);
-    }
-    else {
+    } else {
       $entity_browser = $element['#entity_browser'];
     }
 

Spacing +5 added lines, -5 removed lines

@@ -154,8 +154,8 @@ 
     }
 
     $default_value = implode(' ', array_map(
-      function (EntityInterface $item) {
-        return $item->getEntityTypeId() . ':' . $item->id();
+      function(EntityInterface $item) {
+        return $item->getEntityTypeId().':'.$item->id();
       },
       $entity_browser_preselected_entities
     ));
@@ -189,7 +189,7 @@ 
         ]
       );
 
-      $hidden_id = Html::getUniqueId($element['#id'] . '-target');
+      $hidden_id = Html::getUniqueId($element['#id'].'-target');
       $element['entity_ids'] = [
         '#type' => 'hidden',
         '#id' => $hidden_id,
@@ -202,7 +202,7 @@ 
         $entity_browser->getDisplay()->getUuid() => [
           'cardinality' => $element['#cardinality'],
           'selection_mode' => $element['#selection_mode'],
-          'selector' => '#' . $hidden_id,
+          'selector' => '#'.$hidden_id,
         ],
       ];
     }
@@ -243,7 +243,7 @@ 
     }
 
     return array_map(
-      function ($item) {
+      function($item) {
         list($entity_type, $entity_id) = explode(':', $item);
         return \Drupal::entityTypeManager()->getStorage($entity_type)->load($entity_id);
       },

src/Tests/EntityBrowserUITest.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     $file = File::load(1);
     // Test entity browser token that has upload location configured to
     // public://[current-user:account-name]/.
-    $this->assertEqual($file->getFileUri(), 'public://' . $account->getUsername() . '/' . $file->getFilename(), 'Image has the correct uri.');
+    $this->assertEqual($file->getFileUri(), 'public://'.$account->getUsername().'/'.$file->getFilename(), 'Image has the correct uri.');
   }
 
 }

src/Tests/FormElementTest.php

Spacing +5 added lines, -5 removed lines

@@ -52,22 +52,22 @@
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", '', "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id() . ' ' . $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id().' '.$this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[0]->label() . ', ' . $this->nodes[1]->label();
+    $expected = 'Selected entities: '.$this->nodes[0]->label().', '.$this->nodes[1]->label();
     $this->assertText($expected, 'Selected entities detected.');
 
-    $default_entity = $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id();
+    $default_entity = $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id();
     $this->drupalGet('/test-element', ['query' => ['default_entity' => $default_entity, 'selection_mode' => EntityBrowserElement::SELECTION_MODE_EDIT]]);
     $this->assertLink('Select entities', 0, 'Trigger link found.');
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", $default_entity, "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id() . ' ' . $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id().' '.$this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[1]->label() . ', ' . $this->nodes[0]->label();
+    $expected = 'Selected entities: '.$this->nodes[1]->label().', '.$this->nodes[0]->label();
     $this->assertText($expected, 'Selected entities detected.');
   }
 

src/Tests/EntityBrowserUpdateHookTest.php

Spacing +3 added lines, -3 removed lines

@@ -16,8 +16,8 @@ 
    */
   protected function setDatabaseDumpFiles() {
     $this->databaseDumpFiles = [
-      DRUPAL_ROOT . '/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
-      __DIR__ . '/../../tests/fixtures/update/entity_browser.update-hook-test.php',
+      DRUPAL_ROOT.'/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
+      __DIR__.'/../../tests/fixtures/update/entity_browser.update-hook-test.php',
     ];
   }
 
@@ -53,7 +53,7 @@ 
       ->get('entity_browser.browser.test_update');
 
     $this->assertNull($browser->get('submit_text'), 'Old submit text is gone');
-    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal','New submit text appears on the widget.');
+    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal', 'New submit text appears on the widget.');
   }
 
   /**

src/Plugin/views/field/SelectForm.php

Spacing +2 added lines, -2 removed lines

@@ -25,14 +25,14 @@
    */
   public function getRowId(ResultRow $row) {
     $entity = $this->getEntity($row);
-    return $entity->getEntityTypeId() . ':' . $entity->id();
+    return $entity->getEntityTypeId().':'.$entity->id();
   }
 
   /**
    * {@inheritdoc}
    */
   public function render(ResultRow $values) {
-    return ViewsRenderPipelineMarkup::create('<!--form-item-' . $this->options['id'] . '--' . $this->getRowId($values) . '-->');
+    return ViewsRenderPipelineMarkup::create('<!--form-item-'.$this->options['id'].'--'.$this->getRowId($values).'-->');
   }
 
   /**

src/Plugin/views/display/EntityBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -146,7 +146,7 @@
         $form_element_row_id = $select->getRowId($row);
 
         $substitutions[] = [
-          'placeholder' => '<!--form-item-entity_browser_select--' . $form_element_row_id . '-->',
+          'placeholder' => '<!--form-item-entity_browser_select--'.$form_element_row_id.'-->',
           'field_name' => 'entity_browser_select',
           'row_id' => $form_element_row_id,
         ];

Braces +1 added lines, -2 removed lines

@@ -54,8 +54,7 @@
     // that directly.
     if ($option == 'use_ajax') {
       return TRUE;
-    }
-    else {
+    } else {
       return parent::getOption($option);
     }
   }

src/Plugin/EntityBrowser/Widget/View.php

Spacing +2 added lines, -2 removed lines

@@ -238,13 +238,13 @@
     foreach ($displays as $display) {
       list($view_id, $display_id) = $display;
       $view = $this->entityTypeManager->getStorage('view')->load($view_id);
-      $options[$view_id . '.' . $display_id] = $this->t('@view : @display', array('@view' => $view->label(), '@display' => $view->get('display')[$display_id]['display_title']));
+      $options[$view_id.'.'.$display_id] = $this->t('@view : @display', array('@view' => $view->label(), '@display' => $view->get('display')[$display_id]['display_title']));
     }
 
     $form['view'] = [
       '#type' => 'select',
       '#title' => $this->t('View : View display'),
-      '#default_value' => $this->configuration['view'] . '.' . $this->configuration['view_display'],
+      '#default_value' => $this->configuration['view'].'.'.$this->configuration['view_display'],
       '#options' => $options,
       '#empty_option' => $this->t('- Select a view -'),
       '#required' => TRUE,

Braces +2 added lines, -4 removed lines

@@ -125,8 +125,7 @@ 
         return [
           '#markup' => $this->t('Entity browser select form field not found on a view. <a href=":link">Go fix it</a>!', [':link' => $url]),
         ];
-      }
-      else {
+      } else {
         return [
           '#markup' => $this->t('Entity browser select form field not found on a view. Go fix it!'),
         ];
@@ -184,8 +183,7 @@ 
                 ]);
                 $form_state->setError($form['widget']['view']['entity_browser_select'], $message);
               }
-            }
-            catch (PluginNotFoundException $e) {
+            } catch (PluginNotFoundException $e) {
               $message = $this->t('The Entity Type @type does not exist.', [
                 '@type' => $parts[0],
               ]);