Drupal\entity_browser\PluginConfigurationFormTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	buildConfigurationForm()	0	3	1
A	validateConfigurationForm()	0	1	1
B	submitConfigurationForm()	0	15	5

<?php

/**
 * @file
 * Contains \Drupal\entity_browser\PluginConfigurationFormTrait
 */

namespace Drupal\entity_browser;
use Drupal\Core\Form\FormStateInterface;

/**
 * Provides base form methods for configurable plugins entity browser.
 */
trait PluginConfigurationFormTrait {

  /**
   * Implements PluginFormInterface::buildConfigurationForm().
   */
  public function buildConfigurationForm(array $form, FormStateInterface $form_state) {

The parameter $form_state is not used and could be removed.

    return $form;
  }

  /**
   * Implements PluginFormInterface::validateConfigurationForm().
   */
  public function validateConfigurationForm(array &$form, FormStateInterface $form_state) {}

The parameter $form is not used and could be removed.

The parameter $form_state is not used and could be removed.

  /**
   * Implements PluginFormInterface::submitConfigurationForm().
   *
   * This is the default implementation for the most common cases where the form
   * element names match keys in configuration array. Plugins can override this
   * if they need more complex logic.
   */
  public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {

The parameter $form is not used and could be removed.

    $values = $form_state->getValues();

    if ($this instanceof WidgetInterface) {
      $values = $values[$this->id()];
    }

    if (!empty($values)) {
      foreach ($values as $key => $value) {
        if (isset($this->configuration[$key])) {
          $this->configuration[$key] = $value;

The property configuration does not exist. Did you maybe forget to declare it?

        }
      }
    }
  }

}