drupal-media / entity_browser

src/Plugin/EntityBrowser/FieldWidgetDisplay/RenderedEntity.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
    */
   public function calculateDependencies() {
     $dependencies = parent::calculateDependencies();
-    if ($view_mode = $this->entityTypeManager->getStorage('entity_view_mode')->load($this->configuration['entity_type'] . '.' . $this->configuration['view_mode'])) {
+    if ($view_mode = $this->entityTypeManager->getStorage('entity_view_mode')->load($this->configuration['entity_type'].'.'.$this->configuration['view_mode'])) {
       $dependencies[$view_mode->getConfigDependencyKey()][] = $view_mode->getConfigDependencyName();
     }
     return $dependencies;

src/Plugin/EntityBrowser/SelectionDisplay/MultiStepDisplay.php

Spacing +6 added lines, -6 removed lines

@@ -113,7 +113,7 @@ 
         $display = ['#markup' => $display];
       }
 
-      $form['selected']['items_' . $entity->id() . '_' . $id] = [
+      $form['selected']['items_'.$entity->id().'_'.$id] = [
         '#theme_wrappers' => ['container'],
         '#attributes' => [
           'class' => ['item-container'],
@@ -124,11 +124,11 @@ 
           '#type' => 'submit',
           '#value' => $this->t('Remove'),
           '#submit' => [[get_class($this), 'removeItemSubmit']],
-          '#name' => 'remove_' . $entity->id() . '_' . $id,
+          '#name' => 'remove_'.$entity->id().'_'.$id,
           '#attributes' => [
             'class' => ['entity-browser-remove-selected-entity'],
             'data-row-id' => $id,
-            'data-remove-entity' => 'items_' . $entity->id(),
+            'data-remove-entity' => 'items_'.$entity->id(),
           ],
         ],
         'weight' => [
@@ -290,10 +290,10 @@ 
         foreach ($entity_ids as $entity_pair_info) {
           $last_entity_id = $selected_entities[$selected_entity_keys[$key_index]]->id();
 
-          $html = $renderer->render($form['selection_display']['selected']['items_' . $last_entity_id . '_' . $selected_entity_keys[$key_index]]);
+          $html = $renderer->render($form['selection_display']['selected']['items_'.$last_entity_id.'_'.$selected_entity_keys[$key_index]]);
 
           $ajax->addCommand(
-            new ReplaceCommand('div[id="' . $entity_pair_info['proxy_id'] . '"]', static::trimSingleHtmlTag($html))
+            new ReplaceCommand('div[id="'.$entity_pair_info['proxy_id'].'"]', static::trimSingleHtmlTag($html))
           );
 
           $key_index++;
@@ -367,7 +367,7 @@ 
     // Remove weight of entity being removed.
     $form_state->unsetValue([
       'selected',
-      $triggering_element['#attributes']['data-remove-entity'] . '_' . $triggering_element['#attributes']['data-row-id'],
+      $triggering_element['#attributes']['data-remove-entity'].'_'.$triggering_element['#attributes']['data-row-id'],
     ]);
 
     // Remove entity itself.

src/Tests/ConfigUITest.php

Spacing +13 added lines, -13 removed lines

@@ -146,9 +146,9 @@ 
     $xpath = new \DOMXPath($dom);
     foreach ($commands as $command) {
       if ($command['command'] == 'insert' && $command['method'] == 'replaceWith') {
-        $wrapperNode = $xpath->query('//*[@id="' . ltrim($command['selector'], '#') . '"]')->item(0);
+        $wrapperNode = $xpath->query('//*[@id="'.ltrim($command['selector'], '#').'"]')->item(0);
         $newDom = new \DOMDocument();
-        @$newDom->loadHTML('<div>' . $command['data'] . '</div>');
+        @$newDom->loadHTML('<div>'.$command['data'].'</div>');
         $newNode = @$dom->importNode($newDom->documentElement->firstChild->firstChild, TRUE);
         $wrapperNode->parentNode->replaceChild($newNode, $wrapperNode);
         $content = $dom->saveHTML();
@@ -239,20 +239,20 @@ 
     $this->assertUrl('/admin/config/content/entity_browser/test_entity_browser/selection_display', ['query' => ['js' => 'nojs']]);
 
     $this->drupalPostForm(NULL, [], 'Next');
-    $this->assertFieldById('edit-table-' . $first_uuid . '-label', 'upload', 'Correct value for widget label found.');
-    $this->assertFieldChecked('edit-table-' . $first_uuid . '-form-multiple', 'Accept multiple files option is enabled by default.');
+    $this->assertFieldById('edit-table-'.$first_uuid.'-label', 'upload', 'Correct value for widget label found.');
+    $this->assertFieldChecked('edit-table-'.$first_uuid.'-form-multiple', 'Accept multiple files option is enabled by default.');
     $this->assertText('Multiple uploads will only be accepted if the source field allows more than one value.');
-    $this->assertFieldById('edit-table-' . $first_uuid . '-form-upload-location', 'public://', 'Correct value for upload location found.');
-    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-" . $first_uuid . "-form-submit-text']", 'Select files', 'Correct value for submit text found.');
-    $this->assertFieldById('edit-table-' . $second_uuid . '-label', 'entity_form', 'Correct value for widget label found.');
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-entity-type', 'user', 'Correct value for entity type found.');
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-bundle-select', 'user', 'Correct value for bundle found.');
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-form-mode-form-select', 'register', 'Correct value for form modes found.');
-    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-" . $second_uuid . "-form-submit-text']", 'But some are more equal than others', 'Correct value for submit text found.');
+    $this->assertFieldById('edit-table-'.$first_uuid.'-form-upload-location', 'public://', 'Correct value for upload location found.');
+    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-".$first_uuid."-form-submit-text']", 'Select files', 'Correct value for submit text found.');
+    $this->assertFieldById('edit-table-'.$second_uuid.'-label', 'entity_form', 'Correct value for widget label found.');
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-entity-type', 'user', 'Correct value for entity type found.');
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-bundle-select', 'user', 'Correct value for bundle found.');
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-form-mode-form-select', 'register', 'Correct value for form modes found.');
+    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-".$second_uuid."-form-submit-text']", 'But some are more equal than others', 'Correct value for submit text found.');
 
-    $this->drupalPostForm(NULL, ['table[' . $first_uuid . '][form][multiple]' => FALSE], 'Finish');
+    $this->drupalPostForm(NULL, ['table['.$first_uuid.'][form][multiple]' => FALSE], 'Finish');
     $this->drupalGet('/admin/config/content/entity_browser/test_entity_browser/widgets');
-    $this->assertNoFieldChecked('edit-table-' . $first_uuid . '-form-multiple', 'Accept multiple files option is disabled.');
+    $this->assertNoFieldChecked('edit-table-'.$first_uuid.'-form-multiple', 'Accept multiple files option is disabled.');
 
     $this->drupalLogout();
     $this->drupalGet('/admin/config/content/entity_browser/test_entity_browser');

src/Form/EntityBrowserForm.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
    * {@inheritdoc}
    */
   public function getFormId() {
-    return 'entity_browser_' . $this->entityBrowser->id() . '_form';
+    return 'entity_browser_'.$this->entityBrowser->id().'_form';
   }
 
   /**

Braces +3 added lines, -6 removed lines

@@ -105,8 +105,7 @@ 
     $form_state->set('entity_form_initialized', TRUE);
     if ($this->getRequest()->query->has('uuid')) {
       $form_state->set(['entity_browser', 'instance_uuid'], $this->getRequest()->query->get('uuid'));
-    }
-    else {
+    } else {
       $form_state->set(['entity_browser', 'instance_uuid'], $this->uuidGenerator->generate());
     }
     $form_state->set(['entity_browser', 'selected_entities'], []);
@@ -159,8 +158,7 @@ 
     $widget = $this->entityBrowser->getWidget($current_widget_id);
     if ($widget->access()->isAllowed()) {
       $form[$form['#browser_parts']['widget']] = $widget->getForm($form, $form_state, $this->entityBrowser->getAdditionalWidgetParameters());
-    }
-    else {
+    } else {
       drupal_set_message($this->t('Access to the widget forbidden.'), 'warning');
     }
 
@@ -231,8 +229,7 @@ 
 
     if (!$this->isSelectionCompleted($form_state)) {
       $form_state->setRebuild();
-    }
-    else {
+    } else {
       $this->entityBrowser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
     }
   }

src/EntityBrowserInterface.php

Doc Comments -4 removed lines

@@ -53,8 +53,6 @@ 
   /**
    * Sets the id of the widget selector plugin.
    *
-   * @param string $display
-   *   The id of the widget selector plugin.
    *
    * @return \Drupal\entity_browser\EntityBrowserInterface
    *   The class instance this method is called on.
@@ -64,8 +62,6 @@ 
   /**
    * Sets the id of the selection display plugin.
    *
-   * @param string $display
-   *   The id of the selection display plugin.
    *
    * @return \Drupal\entity_browser\EntityBrowserInterface
    *   The class instance this method is called on.

src/Element/EntityBrowserElement.php

Braces +1 added lines, -2 removed lines

@@ -136,8 +136,7 @@
     /** @var \Drupal\entity_browser\EntityBrowserInterface $entity_browser */
     if (is_string($element['#entity_browser'])) {
       $entity_browser = EntityBrowser::load($element['#entity_browser']);
-    }
-    else {
+    } else {
       $entity_browser = $element['#entity_browser'];
     }
 

Spacing +5 added lines, -5 removed lines

@@ -154,8 +154,8 @@ 
     }
 
     $default_value = implode(' ', array_map(
-      function (EntityInterface $item) {
-        return $item->getEntityTypeId() . ':' . $item->id();
+      function(EntityInterface $item) {
+        return $item->getEntityTypeId().':'.$item->id();
       },
       $entity_browser_preselected_entities
     ));
@@ -189,7 +189,7 @@ 
         ]
       );
 
-      $hidden_id = Html::getUniqueId($element['#id'] . '-target');
+      $hidden_id = Html::getUniqueId($element['#id'].'-target');
       $element['entity_ids'] = [
         '#type' => 'hidden',
         '#id' => $hidden_id,
@@ -202,7 +202,7 @@ 
         $entity_browser->getDisplay()->getUuid() => [
           'cardinality' => $element['#cardinality'],
           'selection_mode' => $element['#selection_mode'],
-          'selector' => '#' . $hidden_id,
+          'selector' => '#'.$hidden_id,
         ],
       ];
     }
@@ -243,7 +243,7 @@ 
     }
 
     return array_map(
-      function ($item) {
+      function($item) {
         list($entity_type, $entity_id) = explode(':', $item);
         return \Drupal::entityTypeManager()->getStorage($entity_type)->load($entity_id);
       },

src/Tests/EntityBrowserUITest.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     $file = File::load(1);
     // Test entity browser token that has upload location configured to
     // public://[current-user:account-name]/.
-    $this->assertEqual($file->getFileUri(), 'public://' . $account->getUsername() . '/' . $file->getFilename(), 'Image has the correct uri.');
+    $this->assertEqual($file->getFileUri(), 'public://'.$account->getUsername().'/'.$file->getFilename(), 'Image has the correct uri.');
   }
 
 }

src/Tests/FormElementTest.php

Spacing +5 added lines, -5 removed lines

@@ -52,22 +52,22 @@
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", '', "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id() . ' ' . $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id().' '.$this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[0]->label() . ', ' . $this->nodes[1]->label();
+    $expected = 'Selected entities: '.$this->nodes[0]->label().', '.$this->nodes[1]->label();
     $this->assertText($expected, 'Selected entities detected.');
 
-    $default_entity = $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id();
+    $default_entity = $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id();
     $this->drupalGet('/test-element', ['query' => ['default_entity' => $default_entity, 'selection_mode' => EntityBrowserElement::SELECTION_MODE_EDIT]]);
     $this->assertLink('Select entities', 0, 'Trigger link found.');
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", $default_entity, "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id() . ' ' . $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id().' '.$this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[1]->label() . ', ' . $this->nodes[0]->label();
+    $expected = 'Selected entities: '.$this->nodes[1]->label().', '.$this->nodes[0]->label();
     $this->assertText($expected, 'Selected entities detected.');
   }
 

src/Tests/EntityBrowserUpdateHookTest.php

Spacing +3 added lines, -3 removed lines

@@ -16,8 +16,8 @@ 
    */
   protected function setDatabaseDumpFiles() {
     $this->databaseDumpFiles = [
-      DRUPAL_ROOT . '/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
-      __DIR__ . '/../../tests/fixtures/update/entity_browser.update-hook-test.php',
+      DRUPAL_ROOT.'/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
+      __DIR__.'/../../tests/fixtures/update/entity_browser.update-hook-test.php',
     ];
   }
 
@@ -53,7 +53,7 @@ 
       ->get('entity_browser.browser.test_update');
 
     $this->assertNull($browser->get('submit_text'), 'Old submit text is gone');
-    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal','New submit text appears on the widget.');
+    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal', 'New submit text appears on the widget.');
   }
 
   /**