drupal-media / entity_browser

src/Plugin/EntityBrowser/Widget/View.php

Braces +2 added lines, -4 removed lines

@@ -124,8 +124,7 @@ 
         return [
           '#markup' => t('Entity browser select form field not found on a view. <a href=":link">Go fix it</a>!', [':link' => $url]),
         ];
-      }
-      else {
+      } else {
         return [
           '#markup' => t('Entity browser select form field not found on a view. Go fix it!'),
         ];
@@ -183,8 +182,7 @@ 
                 ]);
                 $form_state->setError($form['widget']['view']['entity_browser_select'], $message);
               }
-            }
-            catch (PluginNotFoundException $e) {
+            } catch (PluginNotFoundException $e) {
               $message = t('The Entity Type @type does not exist.', [
                 '@type' => $parts[0],
               ]);

Spacing +2 added lines, -2 removed lines

@@ -216,13 +216,13 @@
     foreach ($displays as $display) {
       list($view_id, $display_id) = $display;
       $view = $this->entityManager->getStorage('view')->load($view_id);
-      $options[$view_id . '.' . $display_id] = $this->t('@view : @display', array('@view' => $view->label(), '@display' => $view->get('display')[$display_id]['display_title']));
+      $options[$view_id.'.'.$display_id] = $this->t('@view : @display', array('@view' => $view->label(), '@display' => $view->get('display')[$display_id]['display_title']));
     }
 
     $form['view'] = [
       '#type' => 'select',
       '#title' => $this->t('View : View display'),
-      '#default_value' => $this->configuration['view'] . '.' . $this->configuration['view_display'],
+      '#default_value' => $this->configuration['view'].'.'.$this->configuration['view_display'],
       '#options' => $options,
       '#empty_option' => $this->t('- Select a view -'),
       '#required' => TRUE,

entity_browser.module

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 /**
  * Implements hook_form_alter().
  */
-function entity_browser_form_alter(&$form, FormStateInterface &$form_state) {
+function entity_browser_form_alter(&$form, FormStateInterface&$form_state) {
   $entity_browser_dialog_edit = \Drupal::service('request_stack')->getCurrentRequest()->get('_route');
   if ($entity_browser_dialog_edit == 'entity_browser.edit_form') {
     // Let's allow the save button only.

Braces +1 added lines, -2 removed lines

@@ -122,8 +122,7 @@
           $image->save();
           $file->filesize = $image->getFileSize();
           drupal_set_message(t('The image was resized to fit within the maximum allowed dimensions of %dimensions pixels.', array('%dimensions' => $maximum_dimensions)));
-        }
-        else {
+        } else {
           $errors[] = t('The image exceeds the maximum allowed dimensions.');
         }
       }

src/Wizard/EntityBrowserWizard.php

Doc Comments +1 added lines, -3 removed lines

@@ -34,9 +34,7 @@
    *   The entity manager.
    * @param $tempstore_id
    *   The shared temp store factory collection name.
-   * @param null $machine_name
-   *   The SharedTempStore key for our current wizard values.
-   * @param null $step
+   * @param string|null $step
    *   The current active step of the wizard.
    */
   public function __construct(SharedTempStoreFactory $tempstore, FormBuilderInterface $builder, ClassResolverInterface $class_resolver, EventDispatcherInterface $event_dispatcher, EntityManagerInterface $entity_manager, RouteMatchInterface $route_match, $tempstore_id, $entity_browser = NULL, $step = 'general') {

src/Tests/EntityBrowserUITest.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     $file = File::load(1);
     // Test entity browser token that has upload location configured to
     // public://[current-user:account-name]/
-    $this->assertEqual($file->getFileUri(), 'public://' . $account->getUsername() . '/' . $file->getFilename(), 'Image has the correct uri.');
+    $this->assertEqual($file->getFileUri(), 'public://'.$account->getUsername().'/'.$file->getFilename(), 'Image has the correct uri.');
   }
 
 }

src/Form/EntityBrowserForm.php

Braces +2 added lines, -4 removed lines

@@ -73,8 +73,7 @@ 
     $form_state->set('entity_form_initialized', TRUE);
     if ($this->getRequest()->query->has('uuid')) {
       $form_state->set(['entity_browser', 'instance_uuid'], $this->getRequest()->query->get('uuid'));
-    }
-    else {
+    } else {
       $form_state->set(['entity_browser', 'instance_uuid'], $this->uuidGenerator->generate());
     }
     $form_state->set(['entity_browser', 'selected_entities'], []);
@@ -161,8 +160,7 @@ 
 
     if (!$this->isSelectionCompleted($form_state)) {
       $form_state->setRebuild();
-    }
-    else {
+    } else {
       $this->entity_browser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
     }
   }

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
    * {@inheritdoc}
    */
   public function getFormId() {
-    return 'entity_browser_' . $this->entityBrowser->id() . '_form';
+    return 'entity_browser_'.$this->entityBrowser->id().'_form';
   }
 
   /**

modules/entity_form/entity_browser_entity_form.module

Braces +1 added lines, -2 removed lines

@@ -116,8 +116,7 @@
 
     if (!$this->isSelectionCompleted($form_state)) {
       $form_state->setRebuild();
-    }
-    else {
+    } else {
       $entity_browser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
     }
   }

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
 /**
  * Implements hook_inline_entity_form_reference_form_alter().
  */
-function entity_browser_entity_form_inline_entity_form_reference_form_alter(&$reference_form, FormStateInterface &$form_state) {
+function entity_browser_entity_form_inline_entity_form_reference_form_alter(&$reference_form, FormStateInterface&$form_state) {
   /** @var \Drupal\field\FieldConfigInterface $instance */
   $instance = $form_state->get([
     'inline_entity_form',
@@ -27,7 +27,7 @@ 
   ]);
 
   /** @var \Drupal\Core\Entity\Display\EntityFormDisplayInterface $form_display */
-  $entity_form_id = $instance->getTargetEntityTypeId() . '.' . $instance->getTargetBundle() . '.default';
+  $entity_form_id = $instance->getTargetEntityTypeId().'.'.$instance->getTargetBundle().'.default';
   // TODO - 'default' might become configurable or something else in the future.
   // See https://www.drupal.org/node/2510274
   $form_display = \Drupal::entityTypeManager()->getStorage('entity_form_display')->load($entity_form_id);
@@ -47,7 +47,7 @@ 
   ]));
 
   $cardinality = FieldStorageDefinitionInterface::CARDINALITY_UNLIMITED;
-  if($instance->getFieldStorageDefinition()->get('cardinality') !== $cardinality) {
+  if ($instance->getFieldStorageDefinition()->get('cardinality') !== $cardinality) {
     $cardinality = $instance->getFieldStorageDefinition()->get('cardinality') - $count_existing_selection;
   }
 
@@ -119,7 +119,7 @@ 
   $ief_id = $reference_form['#ief_id'];
   $form_values = NestedArray::getValue($form_state->getValues(), $reference_form['#parents']);
   $attach_entities = EntityBrowserElement::processEntityIds($form_values['entity_browser']['entity_ids']);
-  $entities =& $form_state->get(['inline_entity_form', $ief_id, 'entities']);
+  $entities = & $form_state->get(['inline_entity_form', $ief_id, 'entities']);
 
   // Determine the correct weight of the new element.
   $weight = 0;

src/Plugin/views/field/SelectForm.php

Spacing +2 added lines, -2 removed lines

@@ -30,14 +30,14 @@
    */
   public function getRowId(ResultRow $row) {
     $entity = $row->_entity;
-    return $entity->getEntityTypeId() . ':' . $entity->id();
+    return $entity->getEntityTypeId().':'.$entity->id();
   }
 
   /**
    * {@inheritdoc}
    */
   public function render(ResultRow $values) {
-    return ViewsRenderPipelineMarkup::create('<!--form-item-' . $this->options['id'] . '--' . $this->getRowId($values) . '-->');
+    return ViewsRenderPipelineMarkup::create('<!--form-item-'.$this->options['id'].'--'.$this->getRowId($values).'-->');
   }
 
   /**

src/Element/EntityBrowserElement.php

Spacing +5 added lines, -5 removed lines

@@ -63,8 +63,8 @@ 
     }
 
     $default_value = implode(' ', array_map(
-      function (EntityInterface $item) {
-        return $item->getEntityTypeId() . ':' . $item->id();
+      function(EntityInterface $item) {
+        return $item->getEntityTypeId().':'.$item->id();
       },
       $element['#default_value']
     ));
@@ -85,7 +85,7 @@ 
       ['validators' => $validators, 'selected_entities' => $element['#default_value']]
     );
 
-    $hidden_id = Html::getUniqueId($element['#id'] . '-target');
+    $hidden_id = Html::getUniqueId($element['#id'].'-target');
     $element['entity_ids'] = [
       '#type' => 'hidden',
       '#id' => $hidden_id,
@@ -97,7 +97,7 @@ 
     $element['#attached']['drupalSettings']['entity_browser'] = [
       $entity_browser->getDisplay()->getUuid() => [
         'cardinality' => $element['#cardinality'],
-        'selector' => '#' . $hidden_id,
+        'selector' => '#'.$hidden_id,
       ],
     ];
 
@@ -137,7 +137,7 @@ 
     }
 
     return array_map(
-      function ($item) {
+      function($item) {
         list($entity_type, $entity_id) = explode(':', $item);
         return \Drupal::entityTypeManager()->getStorage($entity_type)->load($entity_id);
       },

Braces +1 added lines, -2 removed lines

@@ -116,8 +116,7 @@
 
     if (!$this->isSelectionCompleted($form_state)) {
       $form_state->setRebuild();
-    }
-    else {
+    } else {
       $entity_browser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
     }
   }

src/Tests/FormElementTest.php

Spacing +5 added lines, -5 removed lines

@@ -51,22 +51,22 @@
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", '', "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id() . ' ' . $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id().' '.$this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[0]->label() . ', ' . $this->nodes[1]->label();
+    $expected = 'Selected entities: '.$this->nodes[0]->label().', '.$this->nodes[1]->label();
     $this->assertText($expected, 'Selected entities detected.');
 
-    $default_entity = $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id();
+    $default_entity = $this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id();
     $this->drupalGet('/test-element', ['query' => ['default_entity' => $default_entity]]);
     $this->assertLink('Select entities', 0, 'Trigger link found.');
     $this->assertFieldByXPath("//input[@type='hidden' and @id='edit-fancy-entity-browser-target']", $default_entity, "Entity browser's hidden element found.");
 
     $edit = [
-      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId() . ':' . $this->nodes[1]->id() . ' ' . $this->nodes[0]->getEntityTypeId() . ':' . $this->nodes[0]->id(),
+      'fancy_entity_browser[entity_ids]' => $this->nodes[1]->getEntityTypeId().':'.$this->nodes[1]->id().' '.$this->nodes[0]->getEntityTypeId().':'.$this->nodes[0]->id(),
     ];
     $this->drupalPostForm(NULL, $edit, 'Submit');
-    $expected = 'Selected entities: ' . $this->nodes[1]->label() . ', ' . $this->nodes[0]->label();
+    $expected = 'Selected entities: '.$this->nodes[1]->label().', '.$this->nodes[0]->label();
     $this->assertText($expected, 'Selected entities detected.');
   }