Completed
Pull Request — 8.x-1.x (#126)
by Janez
01:59
created
src/Plugin/views/display/EntityBrowser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
         $form_element_row_id = $row_id;
91 91
 
92 92
         $substitutions[] = [
93
-          'placeholder' => '<!--form-item-entity_browser_select--' . $form_element_row_id . '-->',
93
+          'placeholder' => '<!--form-item-entity_browser_select--'.$form_element_row_id.'-->',
94 94
           'field_name' => 'entity_browser_select',
95 95
           'row_id' => $form_element_row_id,
96 96
         ];
Please login to merge, or discard this patch.
src/RouteSubscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
       /** @var $browser \Drupal\entity_browser\EntityBrowserInterface */
63 63
       $browser = $this->browserStorage->load($id);
64 64
       if ($route = $browser->route()) {
65
-        $collection->add('entity_browser.' . $browser->id(), $route);
65
+        $collection->add('entity_browser.'.$browser->id(), $route);
66 66
       }
67 67
     }
68 68
 
Please login to merge, or discard this patch.
src/WidgetSelectorInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
    * @return array
31 31
    *   Form structure.
32 32
    */
33
-  public function getForm(array &$form, FormStateInterface &$form_state);
33
+  public function getForm(array &$form, FormStateInterface&$form_state);
34 34
 
35 35
   /**
36 36
    * Sets the default widget.
Please login to merge, or discard this patch.
src/Plugin/EntityBrowser/Display/IFrame.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     // info.
135 135
     $event_object = new RegisterJSCallbacks($this->configuration['entity_browser_id'], $uuid);
136 136
     $event_object->registerCallback('Drupal.entityBrowser.selectionCompleted');
137
-    $event = $this->eventDispatcher->dispatch(Events::REGISTER_JS_CALLBACKS, $event_object );
137
+    $event = $this->eventDispatcher->dispatch(Events::REGISTER_JS_CALLBACKS, $event_object);
138 138
     $original_path = $this->currentPath->getPath();
139 139
     return [
140 140
       '#theme_wrappers' => ['container'],
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             'entity_browser' => [
155 155
               'iframe' => [
156 156
                 $uuid => [
157
-                  'src' => Url::fromRoute('entity_browser.' . $this->configuration['entity_browser_id'], [], [
157
+                  'src' => Url::fromRoute('entity_browser.'.$this->configuration['entity_browser_id'], [], [
158 158
                     'query' => [
159 159
                       'uuid' => $uuid,
160 160
                       'original_path' => $original_path,
@@ -192,13 +192,13 @@  discard block
 block discarded – undo
192 192
   public function propagateSelection(FilterResponseEvent $event) {
193 193
     $render = [
194 194
       'labels' => [
195
-        '#markup' => 'Labels: ' . implode(', ', array_map(function (EntityInterface $item) {return $item->label();}, $this->entities)),
195
+        '#markup' => 'Labels: '.implode(', ', array_map(function(EntityInterface $item) {return $item->label(); }, $this->entities)),
196 196
         '#attached' => [
197 197
           'library' => ['entity_browser/iframe_selection'],
198 198
           'drupalSettings' => [
199 199
             'entity_browser' => [
200 200
               'iframe' => [
201
-                'entities' => array_map(function (EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()];}, $this->entities),
201
+                'entities' => array_map(function(EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()]; }, $this->entities),
202 202
                 'uuid' => $this->request->query->get('uuid'),
203 203
               ],
204 204
             ],
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
    * {@inheritdoc}
225 225
    */
226 226
   public function path() {
227
-    return '/entity-browser/iframe/' . $this->configuration['entity_browser_id'];
227
+    return '/entity-browser/iframe/'.$this->configuration['entity_browser_id'];
228 228
   }
229 229
 
230 230
 }
Please login to merge, or discard this patch.
src/EntityBrowserInterface.php 2 patches
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -59,8 +59,6 @@  discard block
 block discarded – undo
59 59
   /**
60 60
    * Sets the id of the widget selector plugin
61 61
    *
62
-   * @param string $display
63
-   *   The id of the widget selector plugin.
64 62
    *
65 63
    * @return \Drupal\entity_browser\EntityBrowserInterface
66 64
    *   The class instance this method is called on.
@@ -70,8 +68,6 @@  discard block
 block discarded – undo
70 68
   /**
71 69
    * Sets the id of the selection display plugin
72 70
    *
73
-   * @param string $display
74
-   *   The id of the selection display plugin.
75 71
    *
76 72
    * @return \Drupal\entity_browser\EntityBrowserInterface
77 73
    *   The class instance this method is called on.
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 namespace Drupal\entity_browser;
9 9
 
10 10
 use Drupal\Core\Config\Entity\ConfigEntityInterface;
11
-use Drupal\Core\Form\FormStateInterface;
12 11
 
13 12
 /**
14 13
  * Provides an interface defining an entity browser entity.
Please login to merge, or discard this patch.
src/Form/GeneralInfoConfig.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
    *
62 62
    * @param \Drupal\entity_browser\DisplayManager $display_manager
63 63
    *   Entity browser display plugin manager.
64
-   * @param \Drupal\entity_browser\WidgetSelectorManager $widget_selector
64
+   * @param \Drupal\entity_browser\WidgetSelectorManager $widget_selector_manager
65 65
    *   Entity browser widget selector plugin manager.
66 66
    * @param \Drupal\entity_browser\SelectionDisplayManager
67 67
    *   Entity browser selection display plugin manager.
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Drupal\entity_browser\SelectionDisplayManager;
14 14
 use Drupal\entity_browser\WidgetManager;
15 15
 use Drupal\entity_browser\WidgetSelectorManager;
16
-use Drupal\user\SharedTempStore;
17 16
 use Drupal\user\SharedTempStoreFactory;
18 17
 use Symfony\Component\DependencyInjection\ContainerInterface;
19 18
 
Please login to merge, or discard this patch.
src/Controllers/EntityBrowserController.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,8 +116,7 @@
 block discarded – undo
116 116
 
117 117
     if (!$this->isSelectionCompleted($form_state)) {
118 118
       $form_state->setRebuild();
119
-    }
120
-    else {
119
+    } else {
121 120
       $entity_browser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
122 121
     }
123 122
   }
Please login to merge, or discard this patch.
src/Plugin/views/field/SelectForm.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
    * {@inheritdoc}
24 24
    */
25 25
   public function render(ResultRow $values) {
26
-    return ViewsRenderPipelineMarkup::create('<!--form-item-' . $this->options['id'] . '--' . $values->index . '-->');
26
+    return ViewsRenderPipelineMarkup::create('<!--form-item-'.$this->options['id'].'--'.$values->index.'-->');
27 27
   }
28 28
 
29 29
   /**
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
           '#type' => 'checkbox',
63 63
           '#title' => $this->t('Select this item'),
64 64
           '#title_display' => 'invisible',
65
-          '#return_value' => $entity->getEntityTypeId() . ':' . $entity->id(),
65
+          '#return_value' => $entity->getEntityTypeId().':'.$entity->id(),
66 66
           '#attributes' => ['name' => "entity_browser_select[$row_index]"],
67 67
           '#default_value' => NULL,
68 68
         ];
Please login to merge, or discard this patch.
src/Form/WidgetsConfig.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     $form['widget'] = [
76 76
       '#type' => 'select',
77 77
       '#title' => $this->t('Add widget plugin'),
78
-      '#options' => ['_none_' => '- ' . $this->t('Select a widget to add it') . ' -'] + $widgets,
78
+      '#options' => ['_none_' => '- '.$this->t('Select a widget to add it').' -'] + $widgets,
79 79
       '#ajax' => [
80 80
         'callback' => [get_class($this), 'addWidgetCallback'],
81 81
         'wrapper' => 'widgets',
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
       $row['remove'] = [
126 126
         '#type' => 'submit',
127 127
         '#value' => $this->t('Delete'),
128
-        '#name' => 'remove' . $uuid,
128
+        '#name' => 'remove'.$uuid,
129 129
         '#ajax' => [
130 130
           'callback' => [get_class($this), 'addWidgetCallback'],
131 131
           'wrapper' => 'widgets',
Please login to merge, or discard this patch.