PluginConfigurationFormTrait::submitConfigurationForm() - Code Metrics - Inspection of "Config ui" - drupal-media/entity_browser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-1.x (#126)

by Janez

created 2016-01-23 11:11 UTC

submitConfigurationForm() B

↳ Parent: PluginConfigurationFormTrait

Complexity

Conditions	5
Paths	8

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	15
rs	8.8571
c	1
b	0
f	0
cc	5
eloc	8
nc	8
nop	2

<?php

/**
 * @file
 * Contains \Drupal\entity_browser\PluginConfigurationFormTrait
 */

namespace Drupal\entity_browser;
use Drupal\Core\Form\FormStateInterface;

/**
 * Provides base form methods for configurable plugins entity browser.
 */
trait PluginConfigurationFormTrait {

  /**
   * Implements PluginFormInterface::buildConfigurationForm().
   */
  public function buildConfigurationForm(array $form, FormStateInterface $form_state) {

    return $form;
  }

  /**
   * Implements PluginFormInterface::validateConfigurationForm().
   */
  public function validateConfigurationForm(array &$form, FormStateInterface $form_state) {}


  /**
   * Implements PluginFormInterface::submitConfigurationForm().
   *
   * This is the default implementation for the most common cases where the form
   * element names match keys in configuration array. Plugins can override this
   * if they need more complex logic.
   */
  public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {

    $values = $form_state->getValues();

    if ($this instanceof WidgetInterface) {
      $values = $values['table'][$this->uuid()];
    }

    if (!empty($values)) {
      foreach ($values as $key => $value) {
        if (isset($this->configuration[$key])) {
          $this->configuration[$key] = $value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
      }
    }
  }

}


1			<?php
2
3			/**
4			* @file
5			* Contains \Drupal\entity_browser\PluginConfigurationFormTrait
6			*/
7
8			namespace Drupal\entity_browser;
9			use Drupal\Core\Form\FormStateInterface;
10
11			/**
12			* Provides base form methods for configurable plugins entity browser.
13			*/
14			trait PluginConfigurationFormTrait {
15
16			/**
17			* Implements PluginFormInterface::buildConfigurationForm().
18			*/
19			public function buildConfigurationForm(array $form, FormStateInterface $form_state) {
			0 ignored issues – show Unused Code introduced 2015-12-11 12:25 UTC by Report Bug Copy Issue Report The parameter `$form_state` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
20			return $form;
21			}
22
23			/**
24			* Implements PluginFormInterface::validateConfigurationForm().
25			*/
26			public function validateConfigurationForm(array &$form, FormStateInterface $form_state) {}
			0 ignored issues – show Unused Code introduced 2015-12-11 12:25 UTC by Report Bug Copy Issue Report The parameter `$form` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-11 12:25 UTC by Report Bug Copy Issue Report The parameter `$form_state` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
27
28			/**
29			* Implements PluginFormInterface::submitConfigurationForm().
30			*
31			* This is the default implementation for the most common cases where the form
32			* element names match keys in configuration array. Plugins can override this
33			* if they need more complex logic.
34			*/
35			public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {
			0 ignored issues – show Unused Code introduced 2015-12-11 12:25 UTC by Report Bug Copy Issue Report The parameter `$form` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
36			$values = $form_state->getValues();
37
38			if ($this instanceof WidgetInterface) {
39			$values = $values['table'][$this->uuid()];
40			}
41
42			if (!empty($values)) {
43			foreach ($values as $key => $value) {
44			if (isset($this->configuration[$key])) {
45			$this->configuration[$key] = $value;
			0 ignored issues – show Bug introduced 2015-12-11 12:25 UTC by Report Bug Copy Issue Report The property `configuration` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46			}
47			}
48			}
49			}
50
51			}
52

drupal-media / entity_browser

Pull Request — 8.x-1.x (#126)

submitConfigurationForm() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like