EmbedButtonAdminTest::testCKEditorButtonConflict() - Code Metrics - Inspection of "Issue #2864897 by Dave Reid: Added test coverage f..." - drupal-media/embed - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-1.x ( d1e172...cf44d1 )

by Dave

created 2017-03-29 06:56 UTC

EmbedButtonAdminTest::testCKEditorButtonConflict() A

↳ Parent: EmbedButtonAdminTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	10
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	13
rs	9.4285

<?php

namespace Drupal\embed\Tests;

/**
 * Tests the administrative UI.
 *
 * @group embed
 */
class EmbedButtonAdminTest extends EmbedTestBase {

  /**
   * Tests the embed_button administration functionality.
   */
  public function testEmbedButtonAdmin() {
    // Ensure proper access to the Embed settings page.
    $this->drupalGet('admin/config/content/embed');
    $this->assertResponse(403);

    $this->drupalLogin($this->adminUser);
    $this->drupalGet('admin/config/content/embed');
    $this->assertResponse(200);

    // Add embed button.
    $this->clickLink('Add embed button');
    $button_id = strtolower($this->randomMachineName());
    $button_label = $this->randomMachineName();
    $edit = [
      'id' => $button_id,
      'label' => $button_label,
      'type_id' => 'embed_test_default',
    ];
    $this->drupalPostForm(NULL, $edit, 'Save');
    // Ensure that the newly created button is listed.
    $this->drupalGet('admin/config/content/embed');
    $this->assertText($button_label, 'Test embed_button appears on the list page');

    // Edit embed button.
    $this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
    $new_button_label = $this->randomMachineName();
    $edit = [
      'label' => $new_button_label,
    ];
    $this->drupalPostForm(NULL, $edit, 'Save');
    // Ensure that name and label has been changed.
    $this->drupalGet('admin/config/content/embed');
    $this->assertText($new_button_label, 'New label appears on the list page');
    $this->assertNoText($button_label, 'Old label does not appears on the list page');

    // Delete embed button.
    $this->drupalGet('admin/config/content/embed/button/manage/' . $button_id . '/delete');
    $this->drupalPostForm(NULL, [], 'Delete');
    // Ensure that the deleted embed button no longer exists.
    $this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
    $this->assertResponse(404, 'Deleted embed button no longer exists.');
    // Ensure that the deleted button is no longer listed.
    $this->drupalGet('admin/config/content/embed');
    $this->assertNoText($button_label, 'Test embed_button does not appears on the list page');
  }

  public function testButtonValidation() {
    $this->drupalLogin($this->adminUser);
    $button_id = strtolower($this->randomMachineName());
    $edit = [
      'id' => $button_id,
      'label' => $this->randomMachineName(),
      'type_id' => 'embed_test_aircraft',
    ];
    $this->drupalPostAjaxForm('admin/config/content/embed/button/add', $edit, 'type_id');
    $this->assertFieldByName('type_settings[aircraft_type]', 'fixed-wing');

    $edit['type_settings[aircraft_type]'] = 'invalid';
    $this->drupalPostForm(NULL, $edit, 'Save');
    $this->assertText('Cannot select invalid aircraft type.');

    $edit['type_settings[aircraft_type]'] = 'helicopters';
    $this->drupalPostForm(NULL, $edit, 'Save');
    $this->assertText('Helicopters are just rotorcraft.');

    $this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
    $this->assertFieldByName('type_settings[aircraft_type]', 'rotorcraft');
  }

  public function testCKEditorButtonConflict() {
    $this->drupalLogin($this->adminUser);
    $this->drupalGet('admin/config/content/embed/button/add');

    $button_id = strtolower($this->randomMachineName());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $button_label = $this->randomMachineName();
    $edit = array(
      'id' => 'DrupalImage',
      'label' => $button_label,
      'type_id' => 'embed_test_default',
    );
    $this->drupalPostForm(NULL, $edit, 'Save');
  }

}


1			<?php
2
3			namespace Drupal\embed\Tests;
4
5			/**
6			* Tests the administrative UI.
7			*
8			* @group embed
9			*/
10			class EmbedButtonAdminTest extends EmbedTestBase {
11
12			/**
13			* Tests the embed_button administration functionality.
14			*/
15			public function testEmbedButtonAdmin() {
16			// Ensure proper access to the Embed settings page.
17			$this->drupalGet('admin/config/content/embed');
18			$this->assertResponse(403);
19
20			$this->drupalLogin($this->adminUser);
21			$this->drupalGet('admin/config/content/embed');
22			$this->assertResponse(200);
23
24			// Add embed button.
25			$this->clickLink('Add embed button');
26			$button_id = strtolower($this->randomMachineName());
27			$button_label = $this->randomMachineName();
28			$edit = [
29			'id' => $button_id,
30			'label' => $button_label,
31			'type_id' => 'embed_test_default',
32			];
33			$this->drupalPostForm(NULL, $edit, 'Save');
34			// Ensure that the newly created button is listed.
35			$this->drupalGet('admin/config/content/embed');
36			$this->assertText($button_label, 'Test embed_button appears on the list page');
37
38			// Edit embed button.
39			$this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
40			$new_button_label = $this->randomMachineName();
41			$edit = [
42			'label' => $new_button_label,
43			];
44			$this->drupalPostForm(NULL, $edit, 'Save');
45			// Ensure that name and label has been changed.
46			$this->drupalGet('admin/config/content/embed');
47			$this->assertText($new_button_label, 'New label appears on the list page');
48			$this->assertNoText($button_label, 'Old label does not appears on the list page');
49
50			// Delete embed button.
51			$this->drupalGet('admin/config/content/embed/button/manage/' . $button_id . '/delete');
52			$this->drupalPostForm(NULL, [], 'Delete');
53			// Ensure that the deleted embed button no longer exists.
54			$this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
55			$this->assertResponse(404, 'Deleted embed button no longer exists.');
56			// Ensure that the deleted button is no longer listed.
57			$this->drupalGet('admin/config/content/embed');
58			$this->assertNoText($button_label, 'Test embed_button does not appears on the list page');
59			}
60
61			public function testButtonValidation() {
62			$this->drupalLogin($this->adminUser);
63			$button_id = strtolower($this->randomMachineName());
64			$edit = [
65			'id' => $button_id,
66			'label' => $this->randomMachineName(),
67			'type_id' => 'embed_test_aircraft',
68			];
69			$this->drupalPostAjaxForm('admin/config/content/embed/button/add', $edit, 'type_id');
70			$this->assertFieldByName('type_settings[aircraft_type]', 'fixed-wing');
71
72			$edit['type_settings[aircraft_type]'] = 'invalid';
73			$this->drupalPostForm(NULL, $edit, 'Save');
74			$this->assertText('Cannot select invalid aircraft type.');
75
76			$edit['type_settings[aircraft_type]'] = 'helicopters';
77			$this->drupalPostForm(NULL, $edit, 'Save');
78			$this->assertText('Helicopters are just rotorcraft.');
79
80			$this->drupalGet('admin/config/content/embed/button/manage/' . $button_id);
81			$this->assertFieldByName('type_settings[aircraft_type]', 'rotorcraft');
82			}
83
84			public function testCKEditorButtonConflict() {
85			$this->drupalLogin($this->adminUser);
86			$this->drupalGet('admin/config/content/embed/button/add');
87
88			$button_id = strtolower($this->randomMachineName());
			0 ignored issues – show Unused Code introduced 2016-04-11 21:27 UTC by Report Bug Copy Issue Report `$button_id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
89			$button_label = $this->randomMachineName();
90			$edit = array(
91			'id' => 'DrupalImage',
92			'label' => $button_label,
93			'type_id' => 'embed_test_default',
94			);
95			$this->drupalPostForm(NULL, $edit, 'Save');
96			}
97
98			}
99

drupal-media / embed

Push — 8.x-1.x ( d1e172...cf44d1 )

EmbedButtonAdminTest::testCKEditorButtonConflict() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like