Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class PreviewTest extends EmbedTestBase { |
||
11 | |||
12 | const SUCCESS = 'Success!'; |
||
13 | |||
14 | /** |
||
15 | * Tests the route used for generating preview of embedding entities. |
||
16 | */ |
||
17 | public function testPreviewRoute() { |
||
46 | |||
47 | /** |
||
48 | * Performs a request to the embed.preview route. |
||
49 | * |
||
50 | * @param string $filter_format_id |
||
51 | * ID of the filter format. |
||
52 | * @param string $value |
||
53 | * The query string value to include. |
||
54 | * |
||
55 | * @return string |
||
56 | * The retrieved HTML string. |
||
57 | */ |
||
58 | View Code Duplication | public function getRoute($filter_format_id, $value = NULL) { |
|
65 | |||
66 | } |
||
67 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.