graphql.module::graphql_theme() - Code Metrics - Inspection of "WIP: Test framework" - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#489)

by Philipp

created 2018-01-30 11:03 UTC

graphql.module::graphql_theme() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
nc	1
nop	0
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * @file
 * The GraphQL module.
 */

use Drupal\Core\Url;

define('GRAPHQL_SCALAR_PLUGIN', 'scalar');
define('GRAPHQL_FIELD_PLUGIN', 'field');
define('GRAPHQL_MUTATION_PLUGIN', 'mutation');
define('GRAPHQL_INTERFACE_PLUGIN', 'interface');
define('GRAPHQL_UNION_TYPE_PLUGIN', 'union');
define('GRAPHQL_INPUT_TYPE_PLUGIN', 'input');
define('GRAPHQL_TYPE_PLUGIN', 'type');
define('GRAPHQL_ENUM_PLUGIN', 'enum');

/**
 * Implements hook_help().
 */
function graphql_help($routeName) {
  if ($routeName !== 'help.page.graphql') {
    return;
  }

  $title = t('About');
  $description = t('
<p>This module generates and exposes a
  <a href="http://graphql.org/" target="_blank">GraphQL</a> schema for
  <a href="https://www.drupal.org/8" target="_blank">Drupal 8</a> entities,
  and allows you to expose your own custom schema in a consistent way and with
  minimal effort.</p>');

  $help = <<<EOT
<h3>$title</h3>
$description
EOT;

  return $help;
}

/**
 * Implements hook_theme().
 */
function graphql_theme() {
  return [
    'page__graphql_explorer' => [
      'render element' => 'elements',
      'base hook' => 'block',
    ],
    'page__graphql_voyager' => [
      'render element' => 'elements',
      'base hook' => 'block',
    ],
  ];
}

/**
 * Implements hook_graphql_interfaces_alter().
 *
 * Flatten the interface inheritance tree.
 */
function graphql_graphql_interfaces_alter(&$definitions) {
  $interfaces = array_map(function($definition) use ($definitions) {
    return graphql_list_interfaces($definitions, $definition);
  }, $definitions);

  foreach ($interfaces as $index => $list) {
    $definition['interfaces'] = $list;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
  }
}

/**
 * Implements hook_graphql_types_alter().
 *
 * Flatten the interface inheritance tree.
 */
function graphql_graphql_types_alter(&$definitions) {
  $interfaceDefinitions = \Drupal::service('plugin.manager.graphql.interface')->getDefinitions();

  $interfaces = array_map(function($definition) use ($interfaceDefinitions) {
    return graphql_list_interfaces($interfaceDefinitions, $definition);
  }, $definitions);

  foreach ($interfaces as $index => $list) {
    $definitions[$index]['interfaces'] = $list;
  }
}

/**
 * Get a flattened list of a plugins interface inheritance tree.
 *
 * @param array $definitions
 *   The list of interface definitions.
 * @param mixed $definition
 *   A plugin definition.
 *
 * @return string[]
 *   A list of interface names.
 */
function graphql_list_interfaces(array &$definitions, $definition) {
  $parents = array_filter($definitions, function($parent) use ($definition) {
    return in_array($parent['name'], $definition['interfaces']);
  });

  $interfaces = array_reduce(array_map(function($parent) use ($definitions) {
    return graphql_list_interfaces($definitions, $parent);
  }, $parents), 'array_merge', $definition['interfaces']);

  return $interfaces;
}

/**
 * Implements hook_graphql_schema_operations().
 */
function graphql_graphql_schema_operations($pluginId, array $pluginDefinition) {

  $operations = [];

  if (\Drupal::currentUser()->hasPermission('use graphql explorer')) {

    $operations['explorer'] = [
      'title' => 'Explorer',
      'weight' => 10,
      'url' => Url::fromRoute("graphql.explorer.$pluginId"),
    ];
  }

  if (\Drupal::currentUser()->hasPermission('use graphql voyager')) {

    $operations['voyager'] = [
      'title' => 'Voyager',
      'weight' => 10,
      'url' => Url::fromRoute("graphql.voyager.$pluginId"),
    ];
  }

  return $operations;
}


1		<?php
2
3		/**
4		* @file
5		* The GraphQL module.
6		*/
7
8		use Drupal\Core\Url;
9
10		define('GRAPHQL_SCALAR_PLUGIN', 'scalar');
11		define('GRAPHQL_FIELD_PLUGIN', 'field');
12		define('GRAPHQL_MUTATION_PLUGIN', 'mutation');
13		define('GRAPHQL_INTERFACE_PLUGIN', 'interface');
14		define('GRAPHQL_UNION_TYPE_PLUGIN', 'union');
15		define('GRAPHQL_INPUT_TYPE_PLUGIN', 'input');
16		define('GRAPHQL_TYPE_PLUGIN', 'type');
17		define('GRAPHQL_ENUM_PLUGIN', 'enum');
18
19		/**
20		* Implements hook_help().
21		*/
22		function graphql_help($routeName) {
23		if ($routeName !== 'help.page.graphql') {
24		return;
25		}
26
27		$title = t('About');
28		$description = t('
29		<p>This module generates and exposes a
30		<a href="http://graphql.org/" target="_blank">GraphQL</a> schema for
31		<a href="https://www.drupal.org/8" target="_blank">Drupal 8</a> entities,
32		and allows you to expose your own custom schema in a consistent way and with
33		minimal effort.</p>');
34
35		$help = <<<EOT
36		<h3>$title</h3>
37		$description
38		EOT;
39
40		return $help;
41		}
42
43		/**
44		* Implements hook_theme().
45		*/
46		function graphql_theme() {
47		return [
48		'page__graphql_explorer' => [
49		'render element' => 'elements',
50		'base hook' => 'block',
51		],
52		'page__graphql_voyager' => [
53		'render element' => 'elements',
54		'base hook' => 'block',
55		],
56		];
57		}
58
59		/**
60		* Implements hook_graphql_interfaces_alter().
61		*
62		* Flatten the interface inheritance tree.
63		*/
64		function graphql_graphql_interfaces_alter(&$definitions) {
65		$interfaces = array_map(function($definition) use ($definitions) {
66		return graphql_list_interfaces($definitions, $definition);
67		}, $definitions);
68
69		foreach ($interfaces as $index => $list) {
70		$definition['interfaces'] = $list;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report `$definition` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$definition = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
71		}
72		}
73
74		/**
75		* Implements hook_graphql_types_alter().
76		*
77		* Flatten the interface inheritance tree.
78		*/
79		function graphql_graphql_types_alter(&$definitions) {
80		$interfaceDefinitions = \Drupal::service('plugin.manager.graphql.interface')->getDefinitions();
81
82		$interfaces = array_map(function($definition) use ($interfaceDefinitions) {
83		return graphql_list_interfaces($interfaceDefinitions, $definition);
84		}, $definitions);
85
86		foreach ($interfaces as $index => $list) {
87		$definitions[$index]['interfaces'] = $list;
88		}
89		}
90
91		/**
92		* Get a flattened list of a plugins interface inheritance tree.
93		*
94		* @param array $definitions
95		* The list of interface definitions.
96		* @param mixed $definition
97		* A plugin definition.
98		*
99		* @return string[]
100		* A list of interface names.
101		*/
102		function graphql_list_interfaces(array &$definitions, $definition) {
103		$parents = array_filter($definitions, function($parent) use ($definition) {
104		return in_array($parent['name'], $definition['interfaces']);
105		});
106
107		$interfaces = array_reduce(array_map(function($parent) use ($definitions) {
108		return graphql_list_interfaces($definitions, $parent);
109		}, $parents), 'array_merge', $definition['interfaces']);
110
111		return $interfaces;
112		}
113
114		/**
115		* Implements hook_graphql_schema_operations().
116		*/
117		function graphql_graphql_schema_operations($pluginId, array $pluginDefinition) {
		0 ignored issues – show Unused Code introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The parameter `$pluginDefinition` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
118		$operations = [];
119
120	View Code Duplication	if (\Drupal::currentUser()->hasPermission('use graphql explorer')) {
		0 ignored issues – show Duplication introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		$operations['explorer'] = [
122		'title' => 'Explorer',
123		'weight' => 10,
124		'url' => Url::fromRoute("graphql.explorer.$pluginId"),
125		];
126		}
127
128	View Code Duplication	if (\Drupal::currentUser()->hasPermission('use graphql voyager')) {
		0 ignored issues – show Duplication introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		$operations['voyager'] = [
130		'title' => 'Voyager',
131		'weight' => 10,
132		'url' => Url::fromRoute("graphql.voyager.$pluginId"),
133		];
134		}
135
136		return $operations;
137		}
138

drupal-graphql / graphql

Pull Request — 8.x-3.x (#489)

graphql.module::graphql_theme() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like