RequestController::handleBatchRequest() - Code Metrics - Inspection of "Refactoring towards webonyx/graphql-php." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#525)

by Sebastian

created 2018-02-20 08:44 UTC

RequestController::handleBatchRequest() C

↳ Parent: Project

Complexity

Conditions	7
Paths	4

Size

Total Lines	84
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	46
nc	4
nop	2
dl	0
loc	84
rs	6.5389
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Drupal\graphql\Controller;

use Drupal\Core\Cache\CacheableJsonResponse;
use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\graphql\GraphQL\Execution\QueryProcessor;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Handles GraphQL requests.
 */
class RequestController implements ContainerInjectionInterface {

  /**
   * The query processor.
   *
   * @var \Drupal\graphql\GraphQL\Execution\QueryProcessor
   */
  protected $processor;

  /**
   * The service configuration parameters.
   *
   * @var array
   */
  protected $parameters;

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('graphql.query_processor'),
      $container->getParameter('graphql.config')
    );
  }

  /**
   * RequestController constructor.
   *
   * @param \Drupal\graphql\GraphQL\Execution\QueryProcessor $processor
   *   The query processor.
   * @param array $parameters
   *   The service configuration parameters.
   */
  public function __construct(QueryProcessor $processor, array $parameters) {
    $this->processor = $processor;
    $this->parameters = $parameters;
  }

  /**
   * Handles graphql requests.
   *
   * @param string $schema
   *   The name of the schema.
   * @param \GraphQL\Server\OperationParams|\GraphQL\Server\OperationParams[] $operations
   *   The graphql operation(s) to execute.
   *
   * @return \Drupal\Core\Cache\CacheableJsonResponse
   *   The JSON formatted response.
   */
  public function handleRequest($schema, $operations) {
    $debug = !empty($this->parameters['development']);

    if (is_array($operations)) {
      return $this->handleBatch($schema, $operations, $debug);
    }

    return $this->handleSingle($schema, $operations, $debug);
  }

  /**
   * @param $schema
   * @param $operations
   * @param bool $debug
   *
   * @return \Drupal\Core\Cache\CacheableJsonResponse
   */
  protected function handleSingle($schema, $operations, $debug = FALSE) {

    $result = $this->processor->processQuery($schema, $operations, NULL, $debug);
    $response = new CacheableJsonResponse($result);
    $response->addCacheableDependency($result);
    return $response;
  }

  /**
   * @param $schema
   * @param $operations
   * @param bool $debug
   *
   * @return \Drupal\Core\Cache\CacheableJsonResponse
   */
  protected function handleBatch($schema, $operations, $debug = FALSE) {

    $result = $this->processor->processQuery($schema, $operations, NULL, $debug);
    $response = new CacheableJsonResponse($result);

    foreach ($result as $item) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
      $response->addCacheableDependency($result);
    }

    return $response;
  }
}


1		<?php
2
3		namespace Drupal\graphql\Controller;
4
5		use Drupal\Core\Cache\CacheableJsonResponse;
6		use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
7		use Drupal\graphql\GraphQL\Execution\QueryProcessor;
8		use Symfony\Component\DependencyInjection\ContainerInterface;
9
10		/**
11		* Handles GraphQL requests.
12		*/
13		class RequestController implements ContainerInjectionInterface {
14
15		/**
16		* The query processor.
17		*
18		* @var \Drupal\graphql\GraphQL\Execution\QueryProcessor
19		*/
20		protected $processor;
21
22		/**
23		* The service configuration parameters.
24		*
25		* @var array
26		*/
27		protected $parameters;
28
29		/**
30		* {@inheritdoc}
31		*/
32		public static function create(ContainerInterface $container) {
33		return new static(
34		$container->get('graphql.query_processor'),
35		$container->getParameter('graphql.config')
36		);
37		}
38
39		/**
40		* RequestController constructor.
41		*
42		* @param \Drupal\graphql\GraphQL\Execution\QueryProcessor $processor
43		* The query processor.
44		* @param array $parameters
45		* The service configuration parameters.
46		*/
47		public function __construct(QueryProcessor $processor, array $parameters) {
48		$this->processor = $processor;
49		$this->parameters = $parameters;
50		}
51
52		/**
53		* Handles graphql requests.
54		*
55		* @param string $schema
56		* The name of the schema.
57		* @param \GraphQL\Server\OperationParams\|\GraphQL\Server\OperationParams[] $operations
58		* The graphql operation(s) to execute.
59		*
60		* @return \Drupal\Core\Cache\CacheableJsonResponse
61		* The JSON formatted response.
62		*/
63		public function handleRequest($schema, $operations) {
64		$debug = !empty($this->parameters['development']);
65
66		if (is_array($operations)) {
67		return $this->handleBatch($schema, $operations, $debug);
68		}
69
70		return $this->handleSingle($schema, $operations, $debug);
71		}
72
73		/**
74		* @param $schema
75		* @param $operations
76		* @param bool $debug
77		*
78		* @return \Drupal\Core\Cache\CacheableJsonResponse
79		*/
80	View Code Duplication	protected function handleSingle($schema, $operations, $debug = FALSE) {
		0 ignored issues – show Duplication introduced 2018-02-20 08:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		$result = $this->processor->processQuery($schema, $operations, NULL, $debug);
82		$response = new CacheableJsonResponse($result);
83		$response->addCacheableDependency($result);
84		return $response;
85		}
86
87		/**
88		* @param $schema
89		* @param $operations
90		* @param bool $debug
91		*
92		* @return \Drupal\Core\Cache\CacheableJsonResponse
93		*/
94	View Code Duplication	protected function handleBatch($schema, $operations, $debug = FALSE) {
		0 ignored issues – show Duplication introduced 2018-02-20 08:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		$result = $this->processor->processQuery($schema, $operations, NULL, $debug);
96		$response = new CacheableJsonResponse($result);
97
98		foreach ($result as $item) {
		0 ignored issues – show Bug introduced 2018-02-20 08:47 UTC by Report Bug Copy Issue Report The expression `$result` of type `object<Exception>\|object<Throwable>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
99		$response->addCacheableDependency($result);
100		}
101
102		return $response;
103		}
104		}
105

drupal-graphql / graphql

Pull Request — 8.x-3.x (#525)

RequestController::handleBatchRequest() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like