RouteEntity::__construct() - Code Metrics - Inspection of "Deprecated value wrapper objects for cache metadat..." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#497)

by Sebastian

created 2018-02-08 11:12 UTC

RouteEntity::__construct() A

↳ Parent: RouteEntity

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	5
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Routing;

use Drupal\Core\DependencyInjection\DependencySerializationTrait;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\Language\Language;
use Drupal\Core\Language\LanguageManagerInterface;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\TypedData\TranslatableInterface;
use Drupal\Core\Url;
use Drupal\graphql\GraphQL\Cache\CacheableValue;
use Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Youshido\GraphQL\Execution\ResolveInfo;

/**
 * Retrieve the current routes entity, if it is an entity route.
 *
 * TODO: Move this to `InternalUrl` (breaking change).
 *
 * @GraphQLField(
 *   id = "route_entity",
 *   secure = true,
 *   name = "entity",
 *   description = @Translation("The entity belonging to the current url."),
 *   parents = {"EntityCanonicalUrl"},
 *   type = "Entity"
 * )
 */
class RouteEntity extends FieldPluginBase implements ContainerFactoryPluginInterface {

  use DependencySerializationTrait;

  /**
   * The entity type manager.
   *
   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
   */
  protected $entityTypeManager;

  /**
   * The language manager.
   *
   * @var \Drupal\Core\Language\LanguageManagerInterface
   */
  protected $languageManager;

  /**
   * {@inheritdoc}
   */
  public function __construct(
    array $configuration,
    $pluginId,
    $pluginDefinition,
    EntityTypeManagerInterface $entityTypeManager,
    LanguageManagerInterface $languageManager
  ) {
    $this->entityTypeManager = $entityTypeManager;
    $this->languageManager = $languageManager;
    parent::__construct($configuration, $pluginId, $pluginDefinition);
  }

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $pluginId, $pluginDefinition) {
    return new static(
      $configuration,
      $pluginId,
      $pluginDefinition,
      $container->get('entity_type.manager'),
      $container->get('language_manager')
    );
  }

  /**
   * {@inheritdoc}
   */
  public function resolveValues($value, array $args, ResolveInfo $info) {
    if ($value instanceof Url) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
      list(, $entityType) = explode('.', $value->getRouteName());
      $parameters = $value->getRouteParameters();
      $storage = $this->entityTypeManager->getStorage($entityType);
      $entity = $storage->load($parameters[$entityType]);
      $language = $this->languageManager->getCurrentLanguage(Language::TYPE_CONTENT)->getId();

      // Attempt to translate the entity.
      if ($entity instanceof TranslatableInterface && $entity->hasTranslation($language)) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
        $entity = $entity->getTranslation($language);
      }

      $access = $entity->access('view', NULL, TRUE);
      if ($access->isAllowed()) {

        yield $entity->addCacheableDependency($access);
      }
      else {
        yield new CacheableValue(NULL, [$access]);
      }
    }
  }

}


1		<?php
2
3		namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Routing;
4
5		use Drupal\Core\DependencyInjection\DependencySerializationTrait;
6		use Drupal\Core\Entity\EntityTypeManagerInterface;
7		use Drupal\Core\Language\Language;
8		use Drupal\Core\Language\LanguageManagerInterface;
9		use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
10		use Drupal\Core\TypedData\TranslatableInterface;
11		use Drupal\Core\Url;
12		use Drupal\graphql\GraphQL\Cache\CacheableValue;
13		use Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase;
14		use Symfony\Component\DependencyInjection\ContainerInterface;
15		use Youshido\GraphQL\Execution\ResolveInfo;
16
17		/**
18		* Retrieve the current routes entity, if it is an entity route.
19		*
20		* TODO: Move this to `InternalUrl` (breaking change).
21		*
22		* @GraphQLField(
23		* id = "route_entity",
24		* secure = true,
25		* name = "entity",
26		* description = @Translation("The entity belonging to the current url."),
27		* parents = {"EntityCanonicalUrl"},
28		* type = "Entity"
29		* )
30		*/
31		class RouteEntity extends FieldPluginBase implements ContainerFactoryPluginInterface {
		0 ignored issues – show Bug introduced 2017-11-14 15:57 UTC by Report Bug Copy Issue Report There is one abstract method `getPluginDefinition` in this class; you could implement it, or declare this class as abstract. Loading history...
32		use DependencySerializationTrait;
33
34		/**
35		* The entity type manager.
36		*
37		* @var \Drupal\Core\Entity\EntityTypeManagerInterface
38		*/
39		protected $entityTypeManager;
40
41		/**
42		* The language manager.
43		*
44		* @var \Drupal\Core\Language\LanguageManagerInterface
45		*/
46		protected $languageManager;
47
48		/**
49		* {@inheritdoc}
50		*/
51		public function __construct(
52		array $configuration,
53		$pluginId,
54		$pluginDefinition,
55		EntityTypeManagerInterface $entityTypeManager,
56		LanguageManagerInterface $languageManager
57		) {
58		$this->entityTypeManager = $entityTypeManager;
59		$this->languageManager = $languageManager;
60		parent::__construct($configuration, $pluginId, $pluginDefinition);
61		}
62
63		/**
64		* {@inheritdoc}
65		*/
66		public static function create(ContainerInterface $container, array $configuration, $pluginId, $pluginDefinition) {
67		return new static(
68		$configuration,
69		$pluginId,
70		$pluginDefinition,
71		$container->get('entity_type.manager'),
72		$container->get('language_manager')
73		);
74		}
75
76		/**
77		* {@inheritdoc}
78		*/
79		public function resolveValues($value, array $args, ResolveInfo $info) {
80		if ($value instanceof Url) {
		0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The class `Drupal\Core\Url` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
81		list(, $entityType) = explode('.', $value->getRouteName());
82		$parameters = $value->getRouteParameters();
83		$storage = $this->entityTypeManager->getStorage($entityType);
84		$entity = $storage->load($parameters[$entityType]);
85		$language = $this->languageManager->getCurrentLanguage(Language::TYPE_CONTENT)->getId();
86
87		// Attempt to translate the entity.
88		if ($entity instanceof TranslatableInterface && $entity->hasTranslation($language)) {
		0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The class `Drupal\Core\TypedData\TranslatableInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
89		$entity = $entity->getTranslation($language);
90		}
91
92		$access = $entity->access('view', NULL, TRUE);
93	View Code Duplication	if ($access->isAllowed()) {
		0 ignored issues – show Duplication introduced 2018-02-08 11:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		yield $entity->addCacheableDependency($access);
95		}
96		else {
97		yield new CacheableValue(NULL, [$access]);
98		}
99		}
100		}
101
102		}
103

drupal-graphql / graphql

Pull Request — 8.x-3.x (#497)

RouteEntity::__construct() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like