Drupal\graphql_core\Plugin\GraphQL\Fields\Routing\ExternalUrl\ExternalRequest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	58
Duplicated Lines	84.48 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	13	13	1
A	__construct()	9	9	1
A	resolveValues()	0	5	2

<?php

namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Routing\ExternalUrl;

use Drupal\Core\DependencyInjection\DependencySerializationTrait;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Url;
use Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase;
use GuzzleHttp\ClientInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Youshido\GraphQL\Execution\ResolveInfo;

/**
 * Issue an external request and retrieve the response object.
 *
 * @GraphQLField(
 *   id = "external_url_request",
 *   name = "request",
 *   type = "ExternalResponse",
 *   parents = {"ExternalUrl"}
 * )
 */
class ExternalRequest extends FieldPluginBase implements ContainerFactoryPluginInterface {

There is one abstract method getPluginDefinition in this class; you could implement it, or declare this class as abstract.

This class seems to be duplicated in your project.

  use DependencySerializationTrait;

  /**
   * @var \GuzzleHttp\ClientInterface
   */
  protected $httpClient;

  /**
   * {@inheritdoc}
   */
  public static function create(
    ContainerInterface $container,
    array $configuration,
    $plugin_id,
    $plugin_definition
  ) {
    return new static(
      $configuration,
      $plugin_id,
      $plugin_definition,
      $container->get('http_client')
    );
  }

  /**
   * ExternalRequest constructor.
   *
   * @param array $configuration
   *   The plugin configuration array.
   * @param string $pluginId
   *   The plugin id.
   * @param mixed $pluginDefinition
   *   The plugin definition array.
   * @param \GuzzleHttp\ClientInterface $httpClient
   *   The http client service.
   */
  public function __construct(
    array $configuration,
    $pluginId,
    $pluginDefinition,
    ClientInterface $httpClient
  ) {
    parent::__construct($configuration, $pluginId, $pluginDefinition);
    $this->httpClient = $httpClient;
  }


  /**
   * {@inheritdoc}
   */
  protected function resolveValues($value, array $args, ResolveInfo $info) {
    if ($value instanceof Url) {

The class Drupal\Core\Url does not exist. Did you forget a USE statement, or did you not list all dependencies?

      yield $this->httpClient->request('GET', $value->toString());
    }
  }

}