ConfigEntityProperty::resolveValues() - Code Metrics - Inspection of "Adding support for config entities" - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#477)

by Sebastian

created 2018-02-01 14:52 UTC

ConfigEntityProperty::resolveValues() A

↳ Parent: ConfigEntityProperty

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	2
nop	3
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Entity\Config;

use Drupal\graphql_core\Plugin\GraphQL\Fields\EntityFieldBase;
use Youshido\GraphQL\Execution\ResolveInfo;
use Youshido\GraphQL\Type\Scalar\AbstractScalarType;

/**
 * @GraphQLField(
 *   id = "config_entity_property",
 *   secure = true,
 *   nullable = true,
 *   weight = -2,
 *   deriver = "Drupal\graphql_core\Plugin\Deriver\Fields\ConfigEntityPropertyDeriver",
 * )
 */
class ConfigEntityProperty extends EntityFieldBase {


  /**
   * {@inheritdoc}
   */
  public function resolveValues($value, array $args, ResolveInfo $info) {
    $definition = $this->getPluginDefinition();
    $property = $definition['property'];
    $result = $value->get($property);
    if (($type = $info->getReturnType()->getNamedType()) && $type instanceof AbstractScalarType) {
      $result = $type->serialize($result);
    }

    yield $result;
  }

}


1		<?php
2
3		namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Entity\Config;
4
5		use Drupal\graphql_core\Plugin\GraphQL\Fields\EntityFieldBase;
6		use Youshido\GraphQL\Execution\ResolveInfo;
7		use Youshido\GraphQL\Type\Scalar\AbstractScalarType;
8
9		/**
10		* @GraphQLField(
11		* id = "config_entity_property",
12		* secure = true,
13		* nullable = true,
14		* weight = -2,
15		* deriver = "Drupal\graphql_core\Plugin\Deriver\Fields\ConfigEntityPropertyDeriver",
16		* )
17		*/
18	View Code Duplication	class ConfigEntityProperty extends EntityFieldBase {
		0 ignored issues – show Bug introduced 2018-01-24 16:56 UTC by Report Bug Copy Issue Report There is one abstract method `getPluginDefinition` in this class; you could implement it, or declare this class as abstract. Loading history... Duplication introduced 2018-02-01 14:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19
20		/**
21		* {@inheritdoc}
22		*/
23		public function resolveValues($value, array $args, ResolveInfo $info) {
24		$definition = $this->getPluginDefinition();
25		$property = $definition['property'];
26		$result = $value->get($property);
27		if (($type = $info->getReturnType()->getNamedType()) && $type instanceof AbstractScalarType) {
28		$result = $type->serialize($result);
29		}
30
31		yield $result;
32		}
33
34		}
35

drupal-graphql / graphql

Pull Request — 8.x-3.x (#477)

ConfigEntityProperty::resolveValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like