Drupal\graphql\GraphQL\Visitors\CacheMetadataCollector

Complexity

Total Complexity

3

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	isEnabled()	0	3	1
B	getVisitor()	0	25	1

<?php

namespace Drupal\graphql\GraphQL\Visitors;

use Drupal\Core\Cache\RefinableCacheableDependencyInterface;
use GraphQL\Language\AST\NodeKind;
use GraphQL\Language\AST\SelectionSetNode;
use GraphQL\Language\Visitor;
use GraphQL\Validator\Rules\AbstractQuerySecurity;
use GraphQL\Validator\ValidationContext;

class CacheMetadataCollector extends AbstractQuerySecurity {

  /**
   * @var \Drupal\Core\Cache\RefinableCacheableDependencyInterface
   */
  protected $metadata;

  /**
   * @var array
   */
  protected $variables;

  /**
   * CacheMetadataCollector constructor.
   *
   * @param \Drupal\Core\Cache\RefinableCacheableDependencyInterface $metadata
   * @param array|null $variables
   */
  public function __construct(RefinableCacheableDependencyInterface $metadata, array $variables = NULL) {
    $this->metadata = $metadata;
    $this->variables = $variables;

It seems like $variables can be null. However, the property $variables is declared as array. Maybe change the type of the property to array|null or add a type check?

  }

  /**
   * {@inheritdoc}
   */
  protected function isEnabled() {
    return TRUE;
  }

  /**
   * {@inheritdoc}
   */
  public function getVisitor(ValidationContext $context) {
    $this->variables = new \ArrayObject();

It seems like new \ArrayObject() of type object<ArrayObject> is incompatible with the declared type array of property $variables.

    $this->structure = new \ArrayObject();

The property structure does not exist. Did you maybe forget to declare it?

    return $this->invokeIfNeeded($context, [
      NodeKind::SELECTION_SET => function (SelectionSetNode $selectionSet) use ($context) {
        $this->structure = $this->collectFieldASTsAndDefs(
          $context,
          $context->getParentType(),
          $selectionSet,
          NULL,
          $this->structure
        );
      },
      NodeKind::VARIABLE_DEFINITION => function ($definition, &$variables) {

The parameter $variables is not used and could be removed.

        array_push( $this->variables, $definition);
        return Visitor::skipNode();
      },
//      NodeKind::OPERATION_DEFINITION => [

42% of this comment could be valid code. Did you maybe forget this after debugging?

//        'leave' => function () {
//          $foo = '';
//        },
//      ],
    ]);
  }
}