PluginReferenceTrait::__sleep() - Code Metrics - Inspection of "Simplifying type plugin references." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#471)

by Sebastian

created 2018-01-19 15:54 UTC

PluginReferenceTrait::__sleep() A

↳ Parent: PluginReferenceTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	0
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0

<?php

namespace Drupal\graphql\GraphQL;

use Drupal\Component\Plugin\ConfigurablePluginInterface;
use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginInterface;

trait PluginReferenceTrait {

  /**
   * The associated type system plugin.
   *
   * @var \Drupal\graphql\Plugin\GraphQL\TypeSystemPluginInterface
   */
  protected $plugin;

  /**
   * The schema builder object.
   *
   * @var \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface
   */
  protected $builder;

  /**
   * {@inheritdoc}
   */
  public function getPlugin() {
    if (is_array($this->plugin)) {
      $this->plugin = $this->builder->getInstance(
        $this->plugin['type'],
        $this->plugin['id'],
        $this->plugin['configuration']
      );
    }

    return $this->plugin;
  }

  /**
   * {@inheritdoc}
   */
  public function __sleep() {
    // Instead of serializing the referenced plugin, we just serialize the
    // plugin id and configuration.
    if ($this->plugin instanceof TypeSystemPluginInterface) {
      $this->plugin = [

        'id' => $this->plugin->getPluginId(),
        'type' => $this->plugin->getPluginDefinition()['pluginType'],
        'configuration' => $this->plugin instanceof ConfigurablePluginInterface ? $this->plugin->getConfiguration() : [],
if ($x instanceof DoesNotExist) {
    // Do something.
}
      ];
    }

    return array_keys(get_object_vars($this));
  }

}

Pull Request — 8.x-3.x (#471)

PluginReferenceTrait::__sleep() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1			<?php
2
3			namespace Drupal\graphql\GraphQL;
4
5			use Drupal\Component\Plugin\ConfigurablePluginInterface;
6			use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginInterface;
7
8			trait PluginReferenceTrait {
9
10			/**
11			* The associated type system plugin.
12			*
13			* @var \Drupal\graphql\Plugin\GraphQL\TypeSystemPluginInterface
14			*/
15			protected $plugin;
16
17			/**
18			* The schema builder object.
19			*
20			* @var \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface
21			*/
22			protected $builder;
23
24			/**
25			* {@inheritdoc}
26			*/
27			public function getPlugin() {
28			if (is_array($this->plugin)) {
29			$this->plugin = $this->builder->getInstance(
30			$this->plugin['type'],
31			$this->plugin['id'],
32			$this->plugin['configuration']
33			);
34			}
35
36			return $this->plugin;
37			}
38
39			/**
40			* {@inheritdoc}
41			*/
42			public function __sleep() {
43			// Instead of serializing the referenced plugin, we just serialize the
44			// plugin id and configuration.
45			if ($this->plugin instanceof TypeSystemPluginInterface) {
46			$this->plugin = [
			0 ignored issues – show Documentation Bug introduced 2018-01-19 15:39 UTC by Report Bug Copy Issue Report It seems like `array('id' => $this->plu...figuration() : array())` of type `array<string,?,{"id":"?"...","configuration":"?"}>` is incompatible with the declared type `object<Drupal\graphql\Pl...eSystemPluginInterface>` of property `$plugin`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
47			'id' => $this->plugin->getPluginId(),
48			'type' => $this->plugin->getPluginDefinition()['pluginType'],
49			'configuration' => $this->plugin instanceof ConfigurablePluginInterface ? $this->plugin->getConfiguration() : [],
			0 ignored issues – show Bug introduced 2017-11-15 10:20 UTC by Report Bug Copy Issue Report The class `Drupal\Component\Plugin\...igurablePluginInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
50			];
51			}
52
53			return array_keys(get_object_vars($this));
54			}
55
56			}

drupal-graphql / graphql

Pull Request — 8.x-3.x (#471)

PluginReferenceTrait::__sleep() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like