UnionType::getConfigValue() - Code Metrics - Inspection of "Don't read from the cached config." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-3.x ( 2e01b0...c986a7 )

by Sebastian

created 2017-11-15 15:03 UTC

UnionType::getConfigValue() A

↳ Parent: UnionType

Complexity

Conditions	2
Paths	2

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	2
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Drupal\graphql\GraphQL\Type;

use Drupal\graphql\GraphQL\CacheableEdgeInterface;
use Drupal\graphql\GraphQL\CacheableEdgeTrait;
use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginReferenceInterface;
use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginReferenceTrait;
use Drupal\graphql\Plugin\GraphQL\Unions\UnionTypePluginBase;
use Youshido\GraphQL\Config\Object\UnionTypeConfig;
use Youshido\GraphQL\Execution\ResolveInfo;
use Youshido\GraphQL\Type\Union\AbstractUnionType;

class UnionType extends AbstractUnionType implements TypeSystemPluginReferenceInterface, CacheableEdgeInterface  {
  use TypeSystemPluginReferenceTrait;
  use CacheableEdgeTrait;

  /**
   * {@inheritdoc}
   */
  public function __construct(UnionTypePluginBase $plugin, array $config = []) {
    $this->plugin = $plugin;
    $this->config = new UnionTypeConfig($config, $this, TRUE);
  }

  /**
   * {@inheritdoc}
   */
  protected function getConfigValue($key, $default = NULL) {
    return !empty($this->config) ? $this->config->get($key, $default) : $default;
  }

  /**
   * {@inheritdoc}
   */
  public function resolveType($object, ResolveInfo $info = NULL) {

    /** @var \Drupal\graphql\GraphQL\Type\ObjectType $type */
    foreach ($this->getTypes() as $type) {
      if ($type->applies($object, $info)) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $type;
      }
    }

    throw new \Exception(sprintf('Could not resolve type for union type %s.', $this->getName()));
  }

  /**
   * {@inheritdoc}
   */
  public function getTypes() {
    return $this->getConfigValue('types', []);
  }

}


1		<?php
2
3		namespace Drupal\graphql\GraphQL\Type;
4
5		use Drupal\graphql\GraphQL\CacheableEdgeInterface;
6		use Drupal\graphql\GraphQL\CacheableEdgeTrait;
7		use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginReferenceInterface;
8		use Drupal\graphql\Plugin\GraphQL\TypeSystemPluginReferenceTrait;
9		use Drupal\graphql\Plugin\GraphQL\Unions\UnionTypePluginBase;
10		use Youshido\GraphQL\Config\Object\UnionTypeConfig;
11		use Youshido\GraphQL\Execution\ResolveInfo;
12		use Youshido\GraphQL\Type\Union\AbstractUnionType;
13
14		class UnionType extends AbstractUnionType implements TypeSystemPluginReferenceInterface, CacheableEdgeInterface {
15		use TypeSystemPluginReferenceTrait;
16		use CacheableEdgeTrait;
17
18		/**
19		* {@inheritdoc}
20		*/
21		public function __construct(UnionTypePluginBase $plugin, array $config = []) {
22		$this->plugin = $plugin;
23		$this->config = new UnionTypeConfig($config, $this, TRUE);
24		}
25
26		/**
27		* {@inheritdoc}
28		*/
29		protected function getConfigValue($key, $default = NULL) {
30		return !empty($this->config) ? $this->config->get($key, $default) : $default;
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36	View Code Duplication	public function resolveType($object, ResolveInfo $info = NULL) {
		0 ignored issues – show Duplication introduced 2017-11-14 15:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		/** @var \Drupal\graphql\GraphQL\Type\ObjectType $type */
38		foreach ($this->getTypes() as $type) {
39		if ($type->applies($object, $info)) {
		0 ignored issues – show Bug introduced 2017-11-14 15:57 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Youshido\GraphQL\Type\Object\AbstractObjectType` as the method `applies()` does only exist in the following sub-classes of `Youshido\GraphQL\Type\Object\AbstractObjectType`: `Drupal\graphql\GraphQL\Type\ObjectType`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
40		return $type;
41		}
42		}
43
44		throw new \Exception(sprintf('Could not resolve type for union type %s.', $this->getName()));
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50		public function getTypes() {
51		return $this->getConfigValue('types', []);
52		}
53
54		}
55

drupal-graphql / graphql

Push — 8.x-3.x ( 2e01b0...c986a7 )

UnionType::getConfigValue() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like