Schema::getSchemaBuilder() - Code Metrics - Inspection of "Simplifying type plugin references. (#471)" - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-3.x ( d7a068...174067 )

by Sebastian

created 2018-01-19 16:00 UTC

Schema::getSchemaBuilder() A

↳ Parent: Schema

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace Drupal\graphql\GraphQL\Schema;

use Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface;
use Youshido\GraphQL\Config\Schema\SchemaConfig;
use Youshido\GraphQL\Schema\AbstractSchema;

class Schema extends AbstractSchema {

  /**
   * The corresponding plugin for this schema.
   *
   * @var \Drupal\graphql\Plugin\GraphQL\SchemaPluginInterface
   */
  protected $builder;

  /**
   * Schema constructor.
   *
   * @param \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface $builder
   *   The schema builder.
   * @param array $config
   *   The schema configuration array.
   */
  public function __construct(PluggableSchemaBuilderInterface $builder, array $config = []) {
    parent::__construct($config);
    $this->builder = $builder;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
  }

  /**
   * Retrieves the schema's plugin instance.
   *
   * @return \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface
   *   The schema builder.
   */
  public function getSchemaBuilder() {
    return $this->builder;
  }

  /**
   * {@inheritdoc}
   */
  public function build(SchemaConfig $config) {
    // Nothing to do here.
  }

}


1			<?php
2
3			namespace Drupal\graphql\GraphQL\Schema;
4
5			use Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface;
6			use Youshido\GraphQL\Config\Schema\SchemaConfig;
7			use Youshido\GraphQL\Schema\AbstractSchema;
8
9			class Schema extends AbstractSchema {
10
11			/**
12			* The corresponding plugin for this schema.
13			*
14			* @var \Drupal\graphql\Plugin\GraphQL\SchemaPluginInterface
15			*/
16			protected $builder;
17
18			/**
19			* Schema constructor.
20			*
21			* @param \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface $builder
22			* The schema builder.
23			* @param array $config
24			* The schema configuration array.
25			*/
26			public function __construct(PluggableSchemaBuilderInterface $builder, array $config = []) {
27			parent::__construct($config);
28			$this->builder = $builder;
			0 ignored issues – show Documentation Bug introduced 2018-01-19 15:39 UTC by Report Bug Copy Issue Report `$builder` is of type `object<Drupal\graphql\Pl...SchemaBuilderInterface>`, but the property `$builder` was declared to be of type `object<Drupal\graphql\Pl...\SchemaPluginInterface>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
29			}
30
31			/**
32			* Retrieves the schema's plugin instance.
33			*
34			* @return \Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface
35			* The schema builder.
36			*/
37			public function getSchemaBuilder() {
38			return $this->builder;
39			}
40
41			/**
42			* {@inheritdoc}
43			*/
44			public function build(SchemaConfig $config) {
45			// Nothing to do here.
46			}
47
48			}
49

drupal-graphql / graphql

Push — 8.x-3.x ( d7a068...174067 )

Schema::getSchemaBuilder() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like