EntityChanged::buildArguments() - Code Metrics - Inspection of "Date format with default value." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#484)

by Sebastian

created 2018-01-25 15:22 UTC

EntityChanged::buildArguments() A

↳ Parent: EntityChanged

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	1
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Entity;

use Drupal\Core\Entity\EntityChangedInterface;
use Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase;
use Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface;
use Youshido\GraphQL\Execution\ResolveInfo;
use DateTime;

/**
 * Get the entities changed date if available.
 *
 * @GraphQLField(
 *   id = "entity_changed",
 *   secure = true,
 *   name = "entityChanged",
 *   type = "String",
 *   parents = {"Entity"},
 *   arguments = {
 *     "format" = "String"
 *   }
 * )
 */
class EntityChanged extends FieldPluginBase {


  /**
   * {@inheritdoc}
   */
  protected function buildArguments(PluggableSchemaBuilderInterface $schemaBuilder) {
    $arguments = parent::buildArguments($schemaBuilder);

    // Set the default value of the format argument programmatically.
    /** @var \Youshido\GraphQL\Field\AbstractInputField $format */
    $format = $arguments['format'];
    $format->getConfig()->set('defaultValue', DateTime::ISO8601);

    return $arguments;
  }

  /**
   * {@inheritdoc}
   */
  protected function resolveValues($value, array $args, ResolveInfo $info) {
    if ($value instanceof EntityChangedInterface) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
      $datetime = new DateTime();
      $datetime->setTimestamp($value->getChangedTime());
      yield $datetime->format($args['format']);
    }
  }

}


Pull Request — 8.x-3.x (#484)

EntityChanged::buildArguments() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		namespace Drupal\graphql_core\Plugin\GraphQL\Fields\Entity;
4
5		use Drupal\Core\Entity\EntityChangedInterface;
6		use Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase;
7		use Drupal\graphql\Plugin\GraphQL\PluggableSchemaBuilderInterface;
8		use Youshido\GraphQL\Execution\ResolveInfo;
9		use DateTime;
10
11		/**
12		* Get the entities changed date if available.
13		*
14		* @GraphQLField(
15		* id = "entity_changed",
16		* secure = true,
17		* name = "entityChanged",
18		* type = "String",
19		* parents = {"Entity"},
20		* arguments = {
21		* "format" = "String"
22		* }
23		* )
24		*/
25	View Code Duplication	class EntityChanged extends FieldPluginBase {
		0 ignored issues – show Bug introduced 2017-11-14 15:57 UTC by Report Bug Copy Issue Report There is one abstract method `getPluginDefinition` in this class; you could implement it, or declare this class as abstract. Loading history... Duplication introduced 2018-01-25 14:07 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26
27		/**
28		* {@inheritdoc}
29		*/
30		protected function buildArguments(PluggableSchemaBuilderInterface $schemaBuilder) {
31		$arguments = parent::buildArguments($schemaBuilder);
32
33		// Set the default value of the format argument programmatically.
34		/** @var \Youshido\GraphQL\Field\AbstractInputField $format */
35		$format = $arguments['format'];
36		$format->getConfig()->set('defaultValue', DateTime::ISO8601);
37
38		return $arguments;
39		}
40
41		/**
42		* {@inheritdoc}
43		*/
44		protected function resolveValues($value, array $args, ResolveInfo $info) {
45		if ($value instanceof EntityChangedInterface) {
		0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The class `Drupal\Core\Entity\EntityChangedInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
46		$datetime = new DateTime();
47		$datetime->setTimestamp($value->getChangedTime());
48		yield $datetime->format($args['format']);
49		}
50		}
51
52		}
53

drupal-graphql / graphql

Pull Request — 8.x-3.x (#484)

EntityChanged::buildArguments() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like