Processor::doResolve() - Code Metrics - Inspection of "Simplifying resolver handling in processor." - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#432)

by Sebastian

created 2017-11-07 11:30 UTC

Processor::doResolve() C

↳ Parent: Processor

Complexity

Conditions	8
Paths	9

Size

Total Lines	23
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	11
nc	9
nop	3
dl	0
loc	23
rs	6.1403
c	0
b	0
f	0

<?php

namespace Drupal\graphql\GraphQL\Execution;

use Drupal\Core\Cache\CacheableDependencyInterface;
use Drupal\Core\Cache\CacheableMetadata;
use Drupal\graphql\GraphQL\SecureFieldInterface;
use Drupal\graphql\GraphQL\ValueWrapperInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Youshido\GraphQL\Execution\DeferredResolverInterface;
use Youshido\GraphQL\Execution\DeferredResult;
use Youshido\GraphQL\Execution\Processor as BaseProcessor;
use Youshido\GraphQL\Field\FieldInterface;
use Youshido\GraphQL\Parser\Ast\Interfaces\FieldInterface as AstFieldInterface;
use Youshido\GraphQL\Parser\Ast\Query as AstQuery;
use Youshido\GraphQL\Schema\AbstractSchema;

class Processor extends BaseProcessor {
  /**
   * The dependency injection container.
   *
   * @var \Symfony\Component\DependencyInjection\ContainerInterface
   */
  protected $container;

  /**
   * Constructs a Processor object.
   *
   * @param \Symfony\Component\DependencyInjection\ContainerInterface $container
   *   The dependency injection container.
   * @param \Youshido\GraphQL\Schema\AbstractSchema $schema
   *   The GraphQL schema.
   * @param boolean $secure
   *   Indicate that this processor is executing trusted queries.
   */
  public function __construct(ContainerInterface $container, AbstractSchema $schema, $secure = FALSE) {
    parent::__construct($schema);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    $this->container = $container;

    $contexts = $this->executionContext->getContainer();
    $contexts->set('secure', $secure);
    $contexts->set('metadata', new CacheableMetadata());
  }

  /**
   * Return the collected cache metadata from the query.
   *
   * @return \Drupal\Core\Cache\CacheableMetadata
   *   The collected cache metadata from the query.
   */
  public function getQueryCacheMetadata() {
    $metadata = new CacheableMetadata();

    $contexts = $this->executionContext->getContainer();
    if ($contexts->has('metadata')) {
      $metadata->addCacheableDependency($contexts->get('metadata'));
    }

    // Prevent caching if this is a mutation query.
    if (($request = $this->executionContext->getRequest()) && $request->hasMutations()) {
      $metadata->setCacheMaxAge(0);
    }

    return $metadata;
  }

  /**
   * {@inheritdoc}
   */
  protected function doResolve(FieldInterface $field, AstFieldInterface $ast, $parentValue = NULL) {
    $contexts = $this->executionContext->getContainer();

    if ($field instanceof SecureFieldInterface) {
      // If not resolving in a trusted environment, check if the field is secure.
      if ($contexts->has('secure') && !$contexts->get('secure') && !$field->isSecure()) {
        throw new \Exception(sprintf("Unable to resolve insecure field '%s' (%s).", $field->getName(), get_class($field)));
      }
    }

    $value = $this->doResolveValue($field, $ast, $parentValue);
    if ($value instanceof CacheableDependencyInterface && $contexts->has('metadata')) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
      // If the current resolved value returns cache metadata, keep it.
      $contexts->get('metadata')->addCacheableDependency($value);
    }

    // If it's a value wrapper, extract the real value to return.
    if ($value instanceof ValueWrapperInterface) {
      $value = $value->getValue();
    }

    return $value;
  }

  /**
   * Override deferred resolving to use our own DeferredResult class.
   *
   * {@inheritdoc}
   */
  protected function deferredResolve($resolvedValue, callable $callback) {
    if ($resolvedValue instanceof DeferredResolverInterface) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
      $deferredResult = new DeferredResult($resolvedValue, function($result) use ($callback) {
        $contexts = $this->executionContext->getContainer();

        if ($result instanceof CacheableDependencyInterface && $contexts->has('metadata')) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
          $contexts->get('metadata')->addCacheableDependency($result);
        }

        if ($result instanceof ValueWrapperInterface) {
          $result = $result->getValue();
        }

        return call_user_func($callback, $result);
      });

      // Whenever we stumble upon a deferred resolver, append it to the
      // queue to be resolved later.
      $this->deferredResults[] = $deferredResult;
class MyClass { }

$x = new MyClass();
$x->foo = true;
      return $deferredResult;
    }

    // For simple values, invoke the callback immediately.
    return $callback($resolvedValue);
  }

  /**
   * Helper function to resolve a field value.
   *
   * @param \Youshido\GraphQL\Field\FieldInterface $field
   * @param \Youshido\GraphQL\Parser\Ast\Interfaces\FieldInterface $ast
   * @param null $parentValue
   *
   * @return mixed|null
   */
  protected function doResolveValue(FieldInterface $field, AstFieldInterface $ast, $parentValue = NULL) {
    $arguments = $this->parseArgumentsValues($field, $ast);
    $astFields = $ast instanceof AstQuery ? $ast->getFields() : [];
    $resolveInfo = $this->createResolveInfo($field, $astFields);

    if ($field instanceof ContainerAwareInterface) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
      $field->setContainer($this->container);
    }

    return $field->resolve($parentValue, $arguments, $resolveInfo);
  }
}


1			<?php
2
3			namespace Drupal\graphql\GraphQL\Execution;
4
5			use Drupal\Core\Cache\CacheableDependencyInterface;
6			use Drupal\Core\Cache\CacheableMetadata;
7			use Drupal\graphql\GraphQL\SecureFieldInterface;
8			use Drupal\graphql\GraphQL\ValueWrapperInterface;
9			use Symfony\Component\DependencyInjection\ContainerAwareInterface;
10			use Symfony\Component\DependencyInjection\ContainerInterface;
11			use Youshido\GraphQL\Execution\DeferredResolverInterface;
12			use Youshido\GraphQL\Execution\DeferredResult;
13			use Youshido\GraphQL\Execution\Processor as BaseProcessor;
14			use Youshido\GraphQL\Field\FieldInterface;
15			use Youshido\GraphQL\Parser\Ast\Interfaces\FieldInterface as AstFieldInterface;
16			use Youshido\GraphQL\Parser\Ast\Query as AstQuery;
17			use Youshido\GraphQL\Schema\AbstractSchema;
18
19			class Processor extends BaseProcessor {
20			/**
21			* The dependency injection container.
22			*
23			* @var \Symfony\Component\DependencyInjection\ContainerInterface
24			*/
25			protected $container;
26
27			/**
28			* Constructs a Processor object.
29			*
30			* @param \Symfony\Component\DependencyInjection\ContainerInterface $container
31			* The dependency injection container.
32			* @param \Youshido\GraphQL\Schema\AbstractSchema $schema
33			* The GraphQL schema.
34			* @param boolean $secure
35			* Indicate that this processor is executing trusted queries.
36			*/
37			public function __construct(ContainerInterface $container, AbstractSchema $schema, $secure = FALSE) {
38			parent::__construct($schema);
			0 ignored issues – show Documentation introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report `$schema` is of type `object<Youshido\GraphQL\Schema\AbstractSchema>`, but the function expects a `object<Youshido\GraphQL\...cutionContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			$this->container = $container;
40
41			$contexts = $this->executionContext->getContainer();
42			$contexts->set('secure', $secure);
43			$contexts->set('metadata', new CacheableMetadata());
44			}
45
46			/**
47			* Return the collected cache metadata from the query.
48			*
49			* @return \Drupal\Core\Cache\CacheableMetadata
50			* The collected cache metadata from the query.
51			*/
52			public function getQueryCacheMetadata() {
53			$metadata = new CacheableMetadata();
54
55			$contexts = $this->executionContext->getContainer();
56			if ($contexts->has('metadata')) {
57			$metadata->addCacheableDependency($contexts->get('metadata'));
58			}
59
60			// Prevent caching if this is a mutation query.
61			if (($request = $this->executionContext->getRequest()) && $request->hasMutations()) {
62			$metadata->setCacheMaxAge(0);
63			}
64
65			return $metadata;
66			}
67
68			/**
69			* {@inheritdoc}
70			*/
71			protected function doResolve(FieldInterface $field, AstFieldInterface $ast, $parentValue = NULL) {
72			$contexts = $this->executionContext->getContainer();
73
74			if ($field instanceof SecureFieldInterface) {
75			// If not resolving in a trusted environment, check if the field is secure.
76			if ($contexts->has('secure') && !$contexts->get('secure') && !$field->isSecure()) {
77			throw new \Exception(sprintf("Unable to resolve insecure field '%s' (%s).", $field->getName(), get_class($field)));
78			}
79			}
80
81			$value = $this->doResolveValue($field, $ast, $parentValue);
82			if ($value instanceof CacheableDependencyInterface && $contexts->has('metadata')) {
			0 ignored issues – show Bug introduced 2017-11-07 11:32 UTC by Report Bug Copy Issue Report The class `Drupal\Core\Cache\CacheableDependencyInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
83			// If the current resolved value returns cache metadata, keep it.
84			$contexts->get('metadata')->addCacheableDependency($value);
85			}
86
87			// If it's a value wrapper, extract the real value to return.
88			if ($value instanceof ValueWrapperInterface) {
89			$value = $value->getValue();
90			}
91
92			return $value;
93			}
94
95			/**
96			* Override deferred resolving to use our own DeferredResult class.
97			*
98			* {@inheritdoc}
99			*/
100			protected function deferredResolve($resolvedValue, callable $callback) {
101			if ($resolvedValue instanceof DeferredResolverInterface) {
			0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The class `Youshido\GraphQL\Executi...ferredResolverInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
102			$deferredResult = new DeferredResult($resolvedValue, function($result) use ($callback) {
103			$contexts = $this->executionContext->getContainer();
104
105			if ($result instanceof CacheableDependencyInterface && $contexts->has('metadata')) {
			0 ignored issues – show Bug introduced 2017-11-07 11:32 UTC by Report Bug Copy Issue Report The class `Drupal\Core\Cache\CacheableDependencyInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
106			$contexts->get('metadata')->addCacheableDependency($result);
107			}
108
109			if ($result instanceof ValueWrapperInterface) {
110			$result = $result->getValue();
111			}
112
113			return call_user_func($callback, $result);
114			});
115
116			// Whenever we stumble upon a deferred resolver, append it to the
117			// queue to be resolved later.
118			$this->deferredResults[] = $deferredResult;
			0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The property `deferredResults` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
119			return $deferredResult;
120			}
121
122			// For simple values, invoke the callback immediately.
123			return $callback($resolvedValue);
124			}
125
126			/**
127			* Helper function to resolve a field value.
128			*
129			* @param \Youshido\GraphQL\Field\FieldInterface $field
130			* @param \Youshido\GraphQL\Parser\Ast\Interfaces\FieldInterface $ast
131			* @param null $parentValue
132			*
133			* @return mixed\|null
134			*/
135			protected function doResolveValue(FieldInterface $field, AstFieldInterface $ast, $parentValue = NULL) {
136			$arguments = $this->parseArgumentsValues($field, $ast);
137			$astFields = $ast instanceof AstQuery ? $ast->getFields() : [];
138			$resolveInfo = $this->createResolveInfo($field, $astFields);
139
140			if ($field instanceof ContainerAwareInterface) {
			0 ignored issues – show Bug introduced 2017-10-17 14:57 UTC by Report Bug Copy Issue Report The class `Symfony\Component\Depend...ContainerAwareInterface` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
141			$field->setContainer($this->container);
142			}
143
144			return $field->resolve($parentValue, $arguments, $resolveInfo);
145			}
146			}
147

drupal-graphql / graphql

Pull Request — 8.x-3.x (#432)

Processor::doResolve() C

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like