ImageFieldTest::testImageField() - Code Metrics - Inspection of "Graphql core test refactoring" - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#501)

by Philipp

created 2018-02-08 14:58 UTC

ImageFieldTest::testImageField() A

↳ Parent: ImageFieldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	34
nc	1
nop	0
dl	0
loc	53
rs	9.5797
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Drupal\Tests\graphql_core\Kernel\Images;

use Drupal\image\Entity\ImageStyle;
use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;

/**
 * Test file attachments.
 *
 * @group graphql_image
 */
class ImageFieldTest extends GraphQLContentTestBase {

  /**
   * {@inheritdoc}
   */
  public static $modules = [
    'file',
    'image',
  ];

  /**
   * {@inheritdoc}
   */
  protected function setUp() {
    parent::setUp();
    $this->installConfig('image');
    $this->installSchema('file', 'file_usage');
    $this->installEntitySchema('file');
    $this->addField('image', 'image');
  }

  /**
   * Test a simple file field.
   */
  public function testImageField() {
    $a = $this->createNode([
      'title' => 'Node A',
      'type' => 'test',
    ]);

    $a->image->generateSampleItems(1);

    $a->save();


    $style = ImageStyle::load('thumbnail');

    $dimensions = [
      'width' => $a->image[0]->width,
      'height' => $a->image[0]->height,
    ];

    $style->transformDimensions($dimensions, $a->image[0]->entity->getFileUri());

    // TODO: Check cache metadata.
    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheTags([
      'config:field.storage.node.image',
      'entity_bundles',
      'entity_field_info',
      'entity_types',
      'file:1',
      'node:1',
      // TODO: missing image style config cache tags?
    ]);

    $this->assertResults($this->getQueryFromFile('image.gql'), [
      'path' => '/node/' . $a->id(),
    ], [
      'route' => [
        'node' => [
          'image' => [[
            'alt' => $a->image->alt,
            'title' => $a->image->title,
            'entity' => ['url' => $a->image->entity->url()],
            'width' => $a->image[0]->width,
            'height' => $a->image[0]->height,
            'thumbnailImage' => [
              'url' => $style->buildUrl($a->image->entity->uri->value),
              'width' => $dimensions['width'],
              'height' => $dimensions['height'],
            ],
          ]],
        ],
      ],
    ], $metadata);
  }

}


1			<?php
2
3			namespace Drupal\Tests\graphql_core\Kernel\Images;
4
5			use Drupal\image\Entity\ImageStyle;
6			use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;
7
8			/**
9			* Test file attachments.
10			*
11			* @group graphql_image
12			*/
13			class ImageFieldTest extends GraphQLContentTestBase {
14
15			/**
16			* {@inheritdoc}
17			*/
18			public static $modules = [
19			'file',
20			'image',
21			];
22
23			/**
24			* {@inheritdoc}
25			*/
26			protected function setUp() {
27			parent::setUp();
28			$this->installConfig('image');
29			$this->installSchema('file', 'file_usage');
30			$this->installEntitySchema('file');
31			$this->addField('image', 'image');
32			}
33
34			/**
35			* Test a simple file field.
36			*/
37			public function testImageField() {
38			$a = $this->createNode([
39			'title' => 'Node A',
40			'type' => 'test',
41			]);
42
43			$a->image->generateSampleItems(1);
44
45			$a->save();
46
47
48			$style = ImageStyle::load('thumbnail');
49
50			$dimensions = [
51			'width' => $a->image[0]->width,
52			'height' => $a->image[0]->height,
53			];
54
55			$style->transformDimensions($dimensions, $a->image[0]->entity->getFileUri());
56
57			// TODO: Check cache metadata.
58			$metadata = $this->defaultCacheMetaData();
59			$metadata->addCacheTags([
60			'config:field.storage.node.image',
61			'entity_bundles',
62			'entity_field_info',
63			'entity_types',
64			'file:1',
65			'node:1',
66			// TODO: missing image style config cache tags?
67			]);
68
69			$this->assertResults($this->getQueryFromFile('image.gql'), [
70			'path' => '/node/' . $a->id(),
71			], [
72			'route' => [
73			'node' => [
74			'image' => [[
75			'alt' => $a->image->alt,
76			'title' => $a->image->title,
77			'entity' => ['url' => $a->image->entity->url()],
78			'width' => $a->image[0]->width,
79			'height' => $a->image[0]->height,
80			'thumbnailImage' => [
81			'url' => $style->buildUrl($a->image->entity->uri->value),
82			'width' => $dimensions['width'],
83			'height' => $dimensions['height'],
84			],
85			]],
86			],
87			],
88			], $metadata);
89			}
90
91			}
92

drupal-graphql / graphql

Pull Request — 8.x-3.x (#501)

ImageFieldTest::testImageField() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like