EntityBasicFieldsTest::testBasicFields() - Code Metrics - Inspection of "Graphql core test refactoring" - drupal-graphql/graphql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 8.x-3.x (#501)

by Philipp

created 2018-02-08 14:58 UTC

EntityBasicFieldsTest::testBasicFields() A

↳ Parent: EntityBasicFieldsTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	71
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	50
nc	2
nop	0
dl	0
loc	71
rs	9.1369
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Drupal\Tests\graphql_core\Kernel\Entity;

use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;
use DateTime;

/**
 * Test basic entity fields.
 *
 * @group graphql_content
 */
class EntityBasicFieldsTest extends GraphQLContentTestBase {

  public static $modules = [
    'language',
    'content_translation',
  ];

  /**
   * {@inheritdoc}
   */
  protected function setUp() {
    parent::setUp();

    $language = $this->container->get('entity.manager')->getStorage('configurable_language')->create([
      'id' => 'fr',
    ]);
    $language->save();
  }

  /**
   * Set the prophesized permissions.
   *
   * @return string[]
   *   The permissions to set on the prophesized user.
   */
  protected function userPermissions() {
    $perms = parent::userPermissions();
    $perms[] = 'edit any test content';
    return $perms;
  }

  /**
   * Test if the basic fields are available on the interface.
   */
  public function testBasicFields() {
    $user = $this->createUser();

    $node = $this->createNode([
      'title' => 'Node in default language',
      'type' => 'test',
      'status' => 1,
      'uid' => $user->id(),
    ]);

    $translation = $node->addTranslation('fr', ['title' => 'French node']);
    $translation->save();

    $created = (new DateTime())->setTimestamp($node->getCreatedTime())->format(DateTime::ISO8601);
    $changed = (new DateTime())->setTimestamp($node->getChangedTime())->format(DateTime::ISO8601);

    $values = [
      'entityId' => $node->id(),
      'entityUuid' => $node->uuid(),
      'entityLabel' => $node->label(),
      'entityType' => $node->getEntityTypeId(),
      'entityBundle' => $node->bundle(),
      'entityLanguage' => [
        'id' => $node->language()->getId(),
        'name' => $node->language()->getName(),
        'direction' => $node->language()->getDirection(),
        'weight' => $node->language()->getWeight(),
      ],
      'entityRoute' => [
        'internalPath' => '/node/' . $node->id(),
        'aliasedPath' => '/node/' . $node->id(),
      ],
      'entityOwner' => [
        'entityLabel' => $user->label(),
      ],
      'entityTranslation' => [
        'entityLabel' => $translation->label(),
      ],
      // EntityPublishedInterface has been added with 8.3.
      // Below the field will return false.
      'entityPublished' => version_compare(\Drupal::VERSION, '8.3', '<') ? FALSE : TRUE,
      'entityCreated' => $created,
      'entityChanged' => $changed,
      'viewAccess' => TRUE,
      'updateAccess' => TRUE,
      'deleteAccess' => FALSE,
    ];


    $query = $this->getQueryFromFile('basic_fields.gql');

    // TODO: Check cache metadata.
    $metadata = $this->defaultCacheMetaData();
    $metadata->addCacheContexts([
      'languages:language_content',
      'user.node_grants:view',
    ]);

    $metadata->addCacheTags([
      'entity_bundles',
      'entity_field_info',
      'entity_types',
      'node:1',
      'node_list',
      'user:1',
    ]);

    $this->assertResults($query, ['nid' => (int) $node->id()], [
      'node' => ['entities' => [$values]],
    ], $metadata);
  }

}


1			<?php
2
3			namespace Drupal\Tests\graphql_core\Kernel\Entity;
4
5			use Drupal\Tests\graphql_core\Kernel\GraphQLContentTestBase;
6			use DateTime;
7
8			/**
9			* Test basic entity fields.
10			*
11			* @group graphql_content
12			*/
13			class EntityBasicFieldsTest extends GraphQLContentTestBase {
14
15			public static $modules = [
16			'language',
17			'content_translation',
18			];
19
20			/**
21			* {@inheritdoc}
22			*/
23			protected function setUp() {
24			parent::setUp();
25
26			$language = $this->container->get('entity.manager')->getStorage('configurable_language')->create([
27			'id' => 'fr',
28			]);
29			$language->save();
30			}
31
32			/**
33			* Set the prophesized permissions.
34			*
35			* @return string[]
36			* The permissions to set on the prophesized user.
37			*/
38			protected function userPermissions() {
39			$perms = parent::userPermissions();
40			$perms[] = 'edit any test content';
41			return $perms;
42			}
43
44			/**
45			* Test if the basic fields are available on the interface.
46			*/
47			public function testBasicFields() {
48			$user = $this->createUser();
49
50			$node = $this->createNode([
51			'title' => 'Node in default language',
52			'type' => 'test',
53			'status' => 1,
54			'uid' => $user->id(),
55			]);
56
57			$translation = $node->addTranslation('fr', ['title' => 'French node']);
58			$translation->save();
59
60			$created = (new DateTime())->setTimestamp($node->getCreatedTime())->format(DateTime::ISO8601);
61			$changed = (new DateTime())->setTimestamp($node->getChangedTime())->format(DateTime::ISO8601);
62
63			$values = [
64			'entityId' => $node->id(),
65			'entityUuid' => $node->uuid(),
66			'entityLabel' => $node->label(),
67			'entityType' => $node->getEntityTypeId(),
68			'entityBundle' => $node->bundle(),
69			'entityLanguage' => [
70			'id' => $node->language()->getId(),
71			'name' => $node->language()->getName(),
72			'direction' => $node->language()->getDirection(),
73			'weight' => $node->language()->getWeight(),
74			],
75			'entityRoute' => [
76			'internalPath' => '/node/' . $node->id(),
77			'aliasedPath' => '/node/' . $node->id(),
78			],
79			'entityOwner' => [
80			'entityLabel' => $user->label(),
81			],
82			'entityTranslation' => [
83			'entityLabel' => $translation->label(),
84			],
85			// EntityPublishedInterface has been added with 8.3.
86			// Below the field will return false.
87			'entityPublished' => version_compare(\Drupal::VERSION, '8.3', '<') ? FALSE : TRUE,
88			'entityCreated' => $created,
89			'entityChanged' => $changed,
90			'viewAccess' => TRUE,
91			'updateAccess' => TRUE,
92			'deleteAccess' => FALSE,
93			];
94
95
96			$query = $this->getQueryFromFile('basic_fields.gql');
97
98			// TODO: Check cache metadata.
99			$metadata = $this->defaultCacheMetaData();
100			$metadata->addCacheContexts([
101			'languages:language_content',
102			'user.node_grants:view',
103			]);
104
105			$metadata->addCacheTags([
106			'entity_bundles',
107			'entity_field_info',
108			'entity_types',
109			'node:1',
110			'node_list',
111			'user:1',
112			]);
113
114			$this->assertResults($query, ['nid' => (int) $node->id()], [
115			'node' => ['entities' => [$values]],
116			], $metadata);
117			}
118
119			}
120

drupal-graphql / graphql

Pull Request — 8.x-3.x (#501)

EntityBasicFieldsTest::testBasicFields() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like